fix(twig): fix duplicate fractal loader name when extending Twig #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #607.
From what I understand, both components and docs registered a Twig loader named "fractal" so that's why the issue happened. What I don't understand is why it's necessary to register the loader for docs at all - I get that internally docs also have @-handles but I have no idea if it should be used anywhere? Handlebars adapter registers the partial loading globally only for components (I think, I don't understand the code there too much), while Nunjucks behaves more like the Twig adapter code-wise. So I don't even understand what the "normal" behavior should be.
Also, this change might break something - like when some component handles are used in docs files. But since I don't know the backstory on this implementation, I would rather break this now, get some bug reports and fix the issues while learning about the usecases and expected results.