Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clarify architecture, implement PayZen & implement Wompi #53

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from

Conversation

blaggacao
Copy link
Collaborator

@blaggacao blaggacao commented Nov 5, 2023

ERP Companion: frappe/erpnext#40845 🟢
Frappe Companion: frappe/frappe#25952 ✔️ & frappe/frappe#26324 ✔️ & frappe/frappe#26637 ✔️

closes #52

Rendered

@s-aga-r @ankush please let me know what you think of this direction.

  • Merge Frappe Hook update feat: add new payment processing hooks frappe#25952
    • Ensure it is fully backwards compatible
  • Merge ERPNext preparation feat: enable a new payment controller erpnext#40845
    • Implement ERPNext dispatcher for new and old version gateways on Payment Request
    • Ensure it is fully backwards compatible
  • Revise docs (now that the implementation is almost finished) - special note: how to implemeten payment sessions for webshop in the future
  • cleanup old payzen implementation
  • cleanup commit history
  • add wompi implementation
  • write unit tests (new controller, wompi & payzen)
  • Investigate impact of frappe/frappe@59ca074 cc @akhilnarang (removal of response.raise_for_status())

* This implementation is quite eagerly typed to aid with IDE support when implementing a new gateway.

** Walk through screenshots: #53 (comment)

Overview

image

Copy link
Collaborator Author

@blaggacao blaggacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Noetes to self

payments/controllers/payment_gateway_controller.py Outdated Show resolved Hide resolved
payments/controllers/payment_gateway_controller.py Outdated Show resolved Hide resolved
payments/controllers/payment_gateway_controller.py Outdated Show resolved Hide resolved
payments/controllers/payment_gateway_controller.py Outdated Show resolved Hide resolved
payments/controllers/payment_gateway_controller.py Outdated Show resolved Hide resolved
payments/controllers/payment_gateway_controller.py Outdated Show resolved Hide resolved
payments/controllers/payment_gateway_controller.py Outdated Show resolved Hide resolved
payments/controllers/payment_gateway_controller.py Outdated Show resolved Hide resolved
payments/controllers/payment_gateway_controller.py Outdated Show resolved Hide resolved
payments/controllers/payment_gateway_controller.py Outdated Show resolved Hide resolved
@blaggacao

This comment was marked as resolved.

blaggacao added a commit to blaggacao/erpnext that referenced this pull request Apr 2, 2024
blaggacao added a commit to blaggacao/erpnext that referenced this pull request Apr 2, 2024
blaggacao added a commit to blaggacao/erpnext that referenced this pull request Apr 2, 2024
blaggacao added a commit to blaggacao/erpnext that referenced this pull request Apr 2, 2024
blaggacao added a commit to blaggacao/erpnext that referenced this pull request Apr 3, 2024
blaggacao added a commit to blaggacao/erpnext that referenced this pull request Apr 3, 2024
@blaggacao
Copy link
Collaborator Author

Fears are nothing more than a state of mind. - Napoleon Hill


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

What the caterpillar calls the end of the world, the master calls a butterfly. - Richard Bach


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

Watch your thoughts, they become your words Watch your words, they become your actions Watch your actions, they become your habits Watch your habits, they become your character Watch your character, it becomes your destiny. -


Kindly help move this PR forward. Many thanks from Yours Sincerely!

blaggacao added a commit to blaggacao/erpnext that referenced this pull request Jul 18, 2024
@blaggacao
Copy link
Collaborator Author

You may say Im a dreamer, but Im not the only one, I hope someday you will join us, and the world will live as one. - John Lennon


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

I have just three things to teach: simplicity, patience, compassion. These three are your greatest treasures. - Lao Tzu


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

The important thing is this: to be able at any moment to sacrifice what we are for what we could become. - Charles Dubois


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

Obstacles are those frightful things you see when you take your eyes off your goal. - Henry Ford


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@blaggacao
Copy link
Collaborator Author

Our distrust is very expensive. - Ralph Emerson


Kindly help move this PR forward. Many thanks from Yours Sincerely!

blaggacao added a commit to blaggacao/erpnext that referenced this pull request Aug 13, 2024
@blaggacao
Copy link
Collaborator Author

An invincible determination can accomplish almost anything and in this lies the great distinction between great men and little men. - Thomas Fuller


Kindly help move this PR forward. Many thanks from Yours Sincerely!

blaggacao added a commit to blaggacao/erpnext that referenced this pull request Sep 5, 2024
blaggacao added a commit to frappe/erpnext that referenced this pull request Sep 11, 2024
@torstenhoegel
Copy link

@blaggacao what's the state with this? really looking forward to mollie implementation but this seems to block it, right?

@blaggacao
Copy link
Collaborator Author

@torstenhoegel I've been running an evolution of this in production successfully for over half a year now. The work ahead is some elaborate rebasing and cherry picking from that branch, improve test coverage and proceed with polishing and stabilization of the api + a compatibility layer inside erpnext to work with the new gateways.

@torstenhoegel
Copy link

Thanks a lot for the update @blaggacao and for your continued work on this! It’s great to hear that it's been running smoothly in production for so long.

I was wondering, do you have a rough timeline in mind for when the rebasing, test coverage improvements, and the API stabilization might be ready for release? No rush, just curious about when it might be expected.

Thanks again for all your efforts!

@blaggacao
Copy link
Collaborator Author

I hope we'd be measuring weeks not months, though it's not at the top of my priority lust, at this moment. But it didn't fall off, either. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WIP: Rearchitecture
2 participants