feat(notifications): add preview #26519
Conversation
github-actions
bot
added
the
add-test-cases
| @@ -161,6 +161,17 @@ frappe.ui.form.on("Notification", { | |||
| document_type: function (frm) { | |||
| frappe.notification.setup_fieldname_select(frm); | |||
| }, | |||
| preview_document: (frm) => { | |||
| frappe.call({ | |||
There was a problem hiding this comment.
Maybe use frm.call here instead?
I think it's easier to read as you immediately see that a method of the doc gets called.
There was a problem hiding this comment.
I'll leave that to the merger, since the CI is green.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
@akhilnarang Could you also please help me to reopen this one? This is too darn useful to not merge it eventually. It is responsible for a change that some power users are now able to actually manage Notifications in our organization and not just developers (as a matter of reality on the ground). |
|
|
|
@barredterra Maybe you can help reopen this one? 🙏 |
No description provided.