Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: frappe.clear_cache should drop all keys (backport #22156) #26496

Closed

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 21, 2024

We are dropping some keys which are hardcoded in function.

  • this over time might be out of sync with rest of the code.
  • other apps cache stuff too.

Best fix: just clear everything.


This is an automatic backport of pull request #22156 done by [Mergify](https://mergify.com).

We are dropping some keys which are hardcoded in function.

- this over time might be out of sync with rest of the code.
- other apps cache stuff too.

Best fix: just clear everything.

(cherry picked from commit 04a13ca)

# Conflicts:
#	frappe/tests/test_caching.py
@mergify mergify bot added the conflicts label May 21, 2024
@mergify mergify bot assigned ankush May 21, 2024
Copy link
Contributor Author

mergify bot commented May 21, 2024

Cherry-pick of 04a13ca has failed:

On branch mergify/bp/version-14-hotfix/pr-22156
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 04a13ca97c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   frappe/__init__.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/tests/test_caching.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ankush ankush closed this May 28, 2024
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-22156 branch May 28, 2024 10:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant