-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: move payment gateways to the payments app #37182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Fixes #37004. |
s-aga-r
force-pushed
the
MOVE-PAYMENTS-GATEWAYS
branch
from
September 22, 2023 13:24
1ba6215
to
eaafa15
Compare
s-aga-r
force-pushed
the
MOVE-PAYMENTS-GATEWAYS
branch
from
September 22, 2023 13:29
eaafa15
to
ced4f56
Compare
s-aga-r
force-pushed
the
MOVE-PAYMENTS-GATEWAYS
branch
from
September 22, 2023 13:34
ced4f56
to
9554f6e
Compare
nice, finally a clean separation 👍 |
s-aga-r
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
September 27, 2023 07:43
Codecov Report
@@ Coverage Diff @@
## develop #37182 +/- ##
===========================================
+ Coverage 66.76% 66.83% +0.07%
===========================================
Files 793 785 -8
Lines 62423 62041 -382
===========================================
- Hits 41679 41468 -211
+ Misses 20744 20573 -171
|
s-aga-r
changed the title
refactor!: remove payment gateways
refactor!: move payment gateways to the payments app
Oct 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frappe/payments#44