Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: move payment gateways to the payments app #37182

Merged
merged 7 commits into from
Oct 14, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 21, 2023

frappe/payments#44

  • GoCardless Settings
  • GoCardless Mandate
  • GoCardless Templates
  • Mpesa Settings
  • stripe_integration.py
  • Dependencies
  • Fix Imports
  • Fix Unit Tests
  • Patch to delete doctypes
  • Some warning (?) - not required

@bosue
Copy link
Contributor

bosue commented Sep 22, 2023

Fixes #37004.

@ankush
Copy link
Member

ankush commented Sep 25, 2023

nice, finally a clean separation 👍

@s-aga-r s-aga-r marked this pull request as ready for review September 27, 2023 07:43
@s-aga-r s-aga-r requested a review from ankush September 27, 2023 07:45
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #37182 (296b233) into develop (f0859ec) will increase coverage by 0.07%.
Report is 63 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #37182      +/-   ##
===========================================
+ Coverage    66.76%   66.83%   +0.07%     
===========================================
  Files          793      785       -8     
  Lines        62423    62041     -382     
===========================================
- Hits         41679    41468     -211     
+ Misses       20744    20573     -171     
Files Coverage Δ
erpnext/erpnext_integrations/utils.py 0.00% <ø> (-42.23%) ⬇️
...ccounts/doctype/payment_request/payment_request.py 57.09% <0.00%> (-9.90%) ⬇️

... and 19 files with indirect coverage changes

@s-aga-r s-aga-r merged commit afef9dc into frappe:develop Oct 14, 2023
14 checks passed
@s-aga-r s-aga-r changed the title refactor!: remove payment gateways refactor!: move payment gateways to the payments app Oct 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants