chore: remove cmake minium version deprecation warning #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can also update to version 3.10 since this is what is suggested by the migration guide. |
rickstaa
force-pushed
the
fix_cmake_minimum_version_deprication_warning
branch
2 times, most recently
from
22627ef
to
73d954d
Compare
rickstaa
commented
Sep 1, 2023
|
@Maverobot, @marcbone I just fixed the latest CI errors, and I think we are now suitable for a merge 👍🏻. |
|
@rickstaa Thank you for your report and the fix. We will take a loot at this PR. |
rickstaa
force-pushed
the
fix_cmake_minimum_version_deprication_warning
branch
from
73d954d
to
3829763
Compare
|
I rebased this PR onto the develop branch and added a CHANGELOG entry. |
gollth
suggested changes
Sep 4, 2023
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.1.3) | |||
| cmake_minimum_required(VERSION 2.8.3) | |||
There was a problem hiding this comment.
Why is this not updated to 3.10 as well?
There was a problem hiding this comment.
Hey @gollth, thanks for reviewing my PR! I got an error when I updated it to 3.10 since the ROS meta package specs currently require version 2.8.3 (see https://wiki.ros.org/catkin/package.xml#Metapackages and moveit/moveit#1619).
How to reproduce
- Checkout 22627ef#diff-64225d9dae606e899687341a27336f3cfff2889d702f52095a148a4e6d50cb24 or change the CMake version in the
franka_ros/CMakeLists.txtfile toVERSION 3.10. - Use
catkin_maketo build the package. - Be greeted by the following error:
WARNING: The CMakeLists.txt of the metapackage 'franka_ros' contains non standard content. Use the content of the following file instead: /home/ricks/development/work/franka_ros_ws/build/catkin_generated/metapackages/franka_ros/CMakeLists.txtNote
Catkin-tools doesn't have this problem.
rickstaa
force-pushed
the
fix_cmake_minimum_version_deprication_warning
branch
from
3829763
to
a37aee8
Compare
5 tasks
This commit ensure that the cmake minimum version < 3.5 deprecation warning is no longer thrown. The minimum cmake version was updated to 3.10 as this is the version that is recommended by the [ROS noetic migration guide](https://wiki.ros.org/noetic/Migration#Increase_required_CMake_version_to_avoid_author_warning). The meta package cmake version has to be kept on 2.8.3 because of some ROS requirements (see https://wiki.ros.org/catkin/package.xml#Metapackages).
rickstaa
force-pushed
the
fix_cmake_minimum_version_deprication_warning
branch
from
a37aee8
to
ca0394f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is desirable given back-compatibility, but this pull request ensures that the cmake minimum version < 3.5 deprecation warning is no longer thrown: