Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure zooming out doesn't happen #176

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

paazca
Copy link
Contributor

@paazca paazca commented Jul 10, 2021

Attempt at fixing #177
In some cases, pressing an image makes it zoom out.

Gif of the issue:
image

With these proposed changes, images will only zoom out if they're bigger than the viewport.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 10, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d7bf709:

Sandbox Source
@medium-zoom/vanilla-example Configuration

@paazca paazca closed this Jul 10, 2021
@paazca paazca deleted the patch-1 branch July 10, 2021 15:34
@paazca paazca restored the patch-1 branch July 10, 2021 15:50
@paazca paazca reopened this Jul 10, 2021
@francoischalifour
Copy link
Owner

Thanks for the PR @paazca, I'll review it in the next few days!

@tobimori
Copy link

tobimori commented Mar 22, 2022

@francoischalifour When can you review this? I tried it and it fixed the issue for me.

@francoischalifour
Copy link
Owner

@paazca Any chance you also add a test for this?

@transitive-bullshit
Copy link

I've been running into this as well; fix looks solid (same as what I did locally).

@ImTheDeveloper
Copy link

Any chance of this getting merged?

@francoischalifour francoischalifour changed the title Fix image zooming out in some cases fix: ensure zooming out doesn't happen Nov 14, 2022
@francoischalifour francoischalifour merged commit b920940 into francoischalifour:master Nov 14, 2022
@francoischalifour
Copy link
Owner

🎉 This fix was released in v1.0.7.

@paazca paazca deleted the patch-1 branch November 14, 2022 18:53
@transitive-bullshit
Copy link

Thanks @francoischalifour & @paazca 🙏 😄 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants