Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow resource alarm customisation #113

Merged
merged 36 commits into from
Jan 22, 2024
Merged

Allow resource alarm customisation #113

merged 36 commits into from
Jan 22, 2024

Conversation

eoinsha
Copy link
Contributor

@eoinsha eoinsha commented Nov 4, 2023 •
edited

Closes #107

Description

Allows alarm and dashboard configuration to be specified at a resource level using CloudFormation metadata, augmenting the type-level configuration at the top level.
Previously, this was only possible for Functions.

Motivation and Context

See #107

How Has This Been Tested?

Snapshot testing added. Unit tests for dashboards and alarms were extended too.
All test project stacks were deployed and manually checked

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fourTheorem fourTheorem deleted a comment from coveralls Nov 28, 2023
@eoinsha eoinsha marked this pull request as ready for review November 28, 2023 21:35
@eoinsha eoinsha force-pushed the resource-customisation branch 4 times, most recently from b13461c to 4988f57 Compare December 4, 2023 11:54
@eoinsha
chore: use real serverless.yml in snapshot tests
c8f10a1
@eoinsha
chore: sort snapshots by key
34ea56e
@eoinsha
chore: use latest GitHub actions
8ee908f
@eoinsha
chore: use metadata for function alarm config
49acf73
@eoinsha
use more specific types for dashboard
9ea9ea6
@eoinsha
chore: prune unused types
c3a7db7
@eoinsha
feat: allow all resources to have configurable alarms
af7a18c
@eoinsha
feat: allow all resources to have configurable dashboards
41feffe
@eoinsha
chore: add unit tests for resource customised alarms
6dad422
@eoinsha
chore: update deps with npm audit
b6d3605
@eoinsha
fix: remove duplicate metrics from API GW widgets
763a843
@eoinsha
chore: extract and extend Lambda dashboard tests
e775d93
@eoinsha
chore: extract and extend DynamoDB dashboard tests
2d44c59
@eoinsha
chore: extract and extend Kinesis Data Stream dashboard tests
56e4cd2
@eoinsha
chore: extract and extend Step Function dashboard tests
167d4a9
@eoinsha
chore: extract and extend SQS dashboard tests
cb7614a
@eoinsha
chore: extract and extend SNS dashboard tests
dd5e5f3
@eoinsha
chore: extract and extend EventBridge dashboard tests
6f2c416
@eoinsha
chore: extract and extend ECS dashboard tests
227f223
@eoinsha
chore: extract and extend DynamoDB dashboard tests
5bbc9fc
@eoinsha
chore: remove superfluous file
27f725c
@eoinsha
chore: remove superfluous import
f8ed3b8
@eoinsha
fix: metadata syntax for Lambda override in CDK test stacks
6405829
@eoinsha eoinsha requested a review from dlynam01 December 5, 2023 17:04
dlynam01
dlynam01 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@dlynam01 dlynam01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

core/dashboards/tests/dashboard.test.ts Show resolved Hide resolved
core/inputs/general-config.ts Outdated Show resolved Hide resolved
core/inputs/general-config.ts Outdated Show resolved Hide resolved
core/tests/testing-utils.ts Outdated Show resolved Hide resolved
test-utils/snapshot-utils.ts Outdated Show resolved Hide resolved
@eoinsha eoinsha merged commit e73dd0f into main Jan 22, 2024
1 of 3 checks passed
@eoinsha eoinsha deleted the resource-customisation branch January 22, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlynam01 dlynam01 dlynam01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serverless Integration: Allow modifying alarm parameters for cloudformation resources
3 participants
@eoinsha @dlynam01 @JamesKyburz