feat(Spasht):Added new API request to send data back to clearlyDefined #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMishx
added
needs code review
needs test
GSoC-22
GMishx
requested changes
Jul 17, 2022
| @@ -141,6 +141,12 @@ public function Output() | |||
| $typeName = trim(GetParm("typeName", PARM_STRING)); | |||
| $providerName = trim(GetParm("providerName", PARM_STRING)); | |||
|
|
|||
| // Reading contribution data | |||
| $coordinatesInfo = trim(GetParm("jsonStringCoordinates", PARM_STRING)); | |||
There was a problem hiding this comment.
The coordinates should be read from the database for the upload. A client can manipulate the request data and put invalid coordinates.
Comment on lines
+397
to
+416
| $contributionPacket["contributionInfo"] = $contributionInfo; | ||
| $patches =array(); | ||
|
|
||
| $patch = array(); | ||
| $patch["coordinates"] = $coordinatesInfo; | ||
| $revision = array(); | ||
| $contributionFiles = array(); | ||
| $file = array(); | ||
| $file["path"] = ""; | ||
| $file["license"] = ""; | ||
| $file["attributions"] = ""; | ||
|
|
||
| array_push($contributionFiles, $file); | ||
|
|
||
| $revision[$contributionRevision]["files"] = $contributionFiles; | ||
| $patch["revisions"] = $revision; | ||
|
|
||
| array_push($patches, $patch); | ||
| $contributionPacket["patches"] = $patches; | ||
|
|
| $file["license"] = ""; | ||
| $file["attributions"] = ""; | ||
|
|
||
| array_push($contributionFiles, $file); |
There was a problem hiding this comment.
Can be simplified.
Suggested change
| array_push($contributionFiles, $file); | |
| $contributionFiles[] = $file; |
| $revision[$contributionRevision]["files"] = $contributionFiles; | ||
| $patch["revisions"] = $revision; | ||
|
|
||
| array_push($patches, $patch); |
There was a problem hiding this comment.
Same here.
Suggested change
| array_push($patches, $patch); | |
| $patches[] = $patch; |
Comment on lines
+401
to
+407
| $patch["coordinates"] = $coordinatesInfo; | ||
| $revision = array(); | ||
| $contributionFiles = array(); | ||
| $file = array(); | ||
| $file["path"] = ""; | ||
| $file["license"] = ""; | ||
| $file["attributions"] = ""; |
There was a problem hiding this comment.
Create a PHP class for the data structure in src/lib/php/Data/Spasht.
| <tr> | ||
| <td> | ||
| <p style="text-align:left">Title</p> | ||
| <input type="text" id="ContributionTitle" style="width:100%"/> |
There was a problem hiding this comment.
Use required attribute to allow user to understand it is a required field.
| $("#contributionDataValid").val("true"); | ||
| $("#contributtionSubmitButton").submit(); | ||
| } else { | ||
| $("#contributionDataValid").val("false"); |
There was a problem hiding this comment.
There should be a feedback if the data is invalid. Otherwise, user might click on the button and wait for the page to load/do something.
|
Can we take this as medium project in gsoc 2023 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new API request to send data back to clearlyDefined.
Changes
src/spasht/ui/ui-spasht.phpsrc/spasht/ui/template/agent_spasht_contribute.html.twigsrc/spasht/ui/template/agent_spasht.js.twigsrc/spasht/ui/template/agent_spasht_ui_tabs.html.twigHow to test