convert build setup to pyproject.toml #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariobehling
requested changes
May 23, 2024
|
rebased the PR on latest development. |
|
Tested using the new workflow to build and deploy any commit , it seems to work ATM on https://tickets-dev.eventyay.com/. @eMBee for clarity and history prevalence it would be better if you don't force push unless necessary and if you do adding a comment on the reasoning so we don't miss information. It's hard to understand reviews when force-pushes happen. |
marcoag
approved these changes
May 24, 2024
|
Also this PR has unrelated changes like modifications to workflows, not sure how those are related to pryproject.toml. Will go ahead and merge anyway but let's try to keep future PRs scoped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a significant restructuring of the build process. resubmit of PR #59