Add tests for new resources

forseti-security · Dec 5, 2020 · bef3332 · bef3332
1 parent 35c196f
commit bef3332
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 4 deletions.
diff --git a/tests/test_resources.py b/tests/test_resources.py
@@ -25,7 +25,7 @@
 from rpe.resources.gcp import GcpBigtableInstance
 from rpe.resources.gcp import GcpCloudFunction
 from rpe.resources.gcp import GcpComputeInstance
-from rpe.resources.gcp import GcpComputeDisks
+from rpe.resources.gcp import GcpComputeDisk
 from rpe.resources.gcp import GcpDatafusionInstance
 from rpe.resources.gcp import GcpDataprocCluster
 from rpe.resources.gcp import GcpGkeCluster
@@ -95,7 +95,7 @@
             'location': 'us-central1-a',
             'project_id': test_project
         },
-        cls=GcpComputeDisks,
+        cls=GcpComputeDisk,
         resource_type='compute.googleapis.com/Disk',
         name='//compute.googleapis.com/projects/my_project/zones/us-central1-a/disks/my_resource'
     ),

diff --git a/tests/test_resources_cai.py b/tests/test_resources_cai.py
@@ -25,7 +25,8 @@
 from rpe.resources.gcp import GcpBigtableInstance
 from rpe.resources.gcp import GcpCloudFunction
 from rpe.resources.gcp import GcpComputeInstance
-from rpe.resources.gcp import GcpComputeDisks
+from rpe.resources.gcp import GcpComputeDisk
+from rpe.resources.gcp import GcpComputeRegionDisk
 from rpe.resources.gcp import GcpDatafusionInstance
 from rpe.resources.gcp import GcpDataprocCluster
 from rpe.resources.gcp import GcpGkeCluster
@@ -39,6 +40,8 @@
 from rpe.resources.gcp import GcpStorageBucket
 from rpe.resources.gcp import GcpComputeFirewall
 from rpe.resources.gcp import GcpComputeSubnetwork
+from rpe.resources.gcp import GcpIamServiceAccount
+from rpe.resources.gcp import GcpIamServiceAccountKey
 
 client_kwargs = {
     'credentials': Credentials(token='')
@@ -87,7 +90,14 @@
             "name": "//compute.googleapis.com/projects/test-project/zones/us-central1-a/disks/test-resource",
             "asset_type": "compute.googleapis.com/Disk",
         },
-        resource_cls=GcpComputeDisks
+        resource_cls=GcpComputeDisk
+    ),
+    CaiTestCase(
+        data={
+            "name": "//compute.googleapis.com/projects/test-project/regions/us-central1/disks/test-resource",
+            "asset_type": "compute.googleapis.com/RegionDisk",
+        },
+        resource_cls=GcpComputeRegionDisk
     ),
     CaiTestCase(
         data={
@@ -131,6 +141,20 @@
         },
         resource_cls=GcpGkeClusterNodepool
     ),
+    CaiTestCase(
+        data={
+            "name": "//iam.googleapis.com/projects/test-project/serviceAccounts/foo",
+            "asset_type": "iam.googleapis.com/ServiceAccount",
+        },
+        resource_cls=GcpIamServiceAccount
+    ),
+    CaiTestCase(
+        data={
+            "name": "//iam.googleapis.com/projects/test-project/serviceAccounts/foo/keys/bar",
+            "asset_type": "iam.googleapis.com/ServiceAccountKey",
+        },
+        resource_cls=GcpIamServiceAccountKey
+    ),
     CaiTestCase(
         data={
             "name": "//pubsub.googleapis.com/projects/test-project/subscriptions/test-resource",