Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

https://github.com/GoogleCloudPlatform/cloudsql-proxy/issues/385 #73

Closed
wants to merge 1 commit into from

Conversation

exenin
Copy link

@exenin exenin commented Apr 24, 2020

#72

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gkowalski-google
Copy link
Contributor

/gcbrun

@gkowalski-google
Copy link
Contributor

Thanks @exenin for the PR and issue! I ran into this issue as well. I tried updating to GKE master version 1.15.11-gke.9 and was able to work past it (someone in that other issue mentioned not seeing it in 1.15). This is probably the best way to resolve it for 1.14. Not sure why the tests failed, I can look into that if you want to move forward. Before we can merge the PR you will need sign the CLA mentioned above.

@gkowalski-google
Copy link
Contributor

Hi @exenin, pinging on my comment above. Just checking if you are still using 1.14 or if you have tried using 1.15. If still on 1.14 and want this change in, then I can approve and merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants