馃殾Slider warning messages when requests encounter problems #2613
Conversation
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="cb/slider-server-status")
julia> using Pluto |
| const base = trailingslash(launch_params.slider_server_url) | ||
| const hash = await notebookfile_hash | ||
| const graph = await bond_connections | ||
| const graph = bond_connections || {} |
There was a problem hiding this comment.
| const graph = bond_connections || {} | |
| const graph = bond_connections ?? {} |
|
Nice! You should be able to see those typescript errors directly in your IDE, maybe check your setup. You could put the bugfix in a separate PR or a commit to main. |
|
When no sliderserver url is given, we show bonds greyed out, and we show a message about running the notebook when you click on them. Maybe this UI could also be used when the sliderserver is not available for this notebook? Maybe with some extra info at the bottom of the popup? If the PSS will be available soon for a notebook, I think it's nice to say "check back later" because people might actually do that, but if it doesn't seem like it will work in the next hour, we might as well give the "static notebook" UX, maybe with some extra info in a |
If a slider server is still starting and the user interacts with a slider, a HTTP 503 error is thrown and the user is not notified. This PR adds a pop-up which informs the user of the slider server's status.
Otherwise, if the client expects a slider server but for whatever reason (user is offline, slider server crashed, etc.) the request fails, this message is shown:
Finally, a bug was fixed in this PR, where if the initial bondconnections request fails but subsequent staterequests succeed, the client sends faulty state patches. The changes in this PR force the client to continue fetching bondconnections until the request succeeds.