-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(menu): support descriptions in vertical menu #2493
base: develop
Are you sure you want to change the base?
Conversation
@prudho What's the status of this PR? |
If we yould make this the standard config (first text node, then description) also for .ui.menu > .item.vertical {
display: flex;
flex-direction: column;
} |
Ok i think you made it the same way it is done in dropdown menu items (first description, then text). This could be solvable there as well by setting |
I suggest to hold this PR for a while. I've already made a change for vertical menu as a flex item in my current branch based on my last PR #1838. I'm still in progress of fixing merge conflicts since there were too many commits ahead of my PR. |
Description
This PR implements a description in the menu items, which can be right floated or under a text.
Under description can also be displayed in not vertical menu, but right floated no as it looks bloated right now (see screenshots).
Screenshot
Inverted works too:
Description under text works as intended, but not the right floated one. Help is welcome 😃
Closes
#2232