Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): dont resize on ios touchmove #2451

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
+9 −0
Draft

fix(sidebar): dont resize on ios touchmove #2451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5976eaa
fix(sidebar): dont resize on ios touchmove
lubber-de Sep 10, 2022
dd24156
Merge branch 'develop' into ios13resize
lubber-de Dec 6, 2022
84b5dcf
Merge branch 'develop' into ios13resize
lubber-de Dec 9, 2022
23106f3
Merge branch 'develop' into ios13resize
lubber-de Dec 12, 2022
565566e
Merge branch 'develop' into ios13resize
lubber-de Dec 15, 2022
86a09c7
Merge branch 'develop' into ios13resize
lubber-de Dec 17, 2022
9f2d9fa
Merge branch 'develop' into ios13resize
lubber-de Dec 21, 2022
607aa4c
Merge branch 'develop' into ios13resize
lubber-de Dec 25, 2022
31c7560
Merge branch 'develop' into ios13resize
lubber-de Mar 19, 2023
d719cbb
feat(sidebar): linting fixes
lubber-de Mar 19, 2023
acd1aa8
Merge branch 'develop' into ios13resize
lubber-de Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/definitions/modules/sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@
module.debug('Initializing sidebar', parameters);

module.create.id();
if (module.is.ios()) {
module.set.ios();
}

// avoids locking rendering if initialized in onReady
if (settings.delaySetup) {
Expand Down
4 changes: 4 additions & 0 deletions src/definitions/modules/sidebar.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,10 @@ body.pushable > .pusher {
iOS
--------------- */

html.ios .ui.sidebar {
touch-action: @iOStouchAction;
}

/*******************************
Variations
*******************************/
Expand Down
2 changes: 2 additions & 0 deletions src/themes/default/modules/sidebar.variables
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
@topLayer: 102;
@dimmerLayer: 1000;

@iOStouchAction: pan-y;

/* -------------------
Variations
-------------------- */
Expand Down