gcc: fix -Wnvro warning #4254
Closed
gcc: fix -Wnvro warning #4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the copiler to elide the copy. Signed-off-by: Rosen Penev <[email protected]>
mwinterb
reviewed
Dec 5, 2024
| @@ -1718,8 +1718,9 @@ auto find_escape(const Char* begin, const Char* end) | |||
|
|
|||
| inline auto find_escape(const char* begin, const char* end) | |||
| -> find_escape_result<char> { | |||
| if (const_check(!use_utf8)) return find_escape<char>(begin, end); | |||
| auto result = find_escape_result<char>{end, nullptr, 0}; | |||
| auto result = find_escape<char>(begin, end); | |||
There was a problem hiding this comment.
is not eliding the 24 byte copy slower than unconditionally calling find_escape<char>?
|
Thanks for the PR but unconditionally calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the copiler to elide the copy.