Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add integration test for accessing sd sttr in dc #2969

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

JiangJiaWei1103
Copy link
Contributor

@JiangJiaWei1103 JiangJiaWei1103 commented Nov 30, 2024

Tracking issue

flyteorg/flyte#5956

Why are the changes needed?

So far, this patch is tested via single binary, which is limited. The newly released flyte now supports accessing StructuredDataset attribute in a dataclass. Hence, we should add an integration to enhance the robustness.

What changes were proposed in this pull request?

Add an integration test supporting:

  1. Upload a single parquet file to minio s3 bucket
  2. Access StructuredDataset attribute from a dataclass
  3. Open StructuredDataset from a remote path (i.e., the uploaded location)
  4. Teardown the uploaded file after workflow is completed

How was this patch tested?

This integration test passes in local run.

Setup process

For local run, the setup process is summarized as follows:

git clone https://github.com/flyteorg/flytekit.git
gh pr checkout 2969
make setup && pip install -e .

After installation, run the following command:

pytest -svvv tests/flytekit/integration/remote/test_remote.py::test_attr_access_sd

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#2954

Docs link

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (92d87a8) to head (fbfac6e).
Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
- Coverage   82.79%   77.53%   -5.26%     
==========================================
  Files           3      288     +285     
  Lines         186    24695   +24509     
  Branches        0     2729    +2729     
==========================================
+ Hits          154    19148   +18994     
- Misses         32     4786    +4754     
- Partials        0      761     +761     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

1. Upload a local parquet file to minio s3 bucket
2. Access StructuredDataset attr from a dataclass
3. Open StructuredDataset from a remote path

Signed-off-by: JiaWei Jiang <[email protected]>
@JiangJiaWei1103 JiangJiaWei1103 changed the title [WIP] Add integration test for accessing sd sttr in dc Add integration test for accessing sd sttr in dc Dec 22, 2024
@JiangJiaWei1103 JiangJiaWei1103 changed the title Add integration test for accessing sd sttr in dc [test] Add integration test for accessing sd sttr in dc Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

1 participant