-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Add integration test for accessing sd sttr in dc #2969
Open
JiangJiaWei1103
wants to merge
7
commits into
flyteorg:master
Choose a base branch
from
JiangJiaWei1103:add-integ-test-for-attr-access-sd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[test] Add integration test for accessing sd sttr in dc #2969
JiangJiaWei1103
wants to merge
7
commits into
flyteorg:master
from
JiangJiaWei1103:add-integ-test-for-attr-access-sd
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JiaWei Jiang <[email protected]>
Signed-off-by: JiaWei Jiang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2969 +/- ##
==========================================
- Coverage 82.79% 77.53% -5.26%
==========================================
Files 3 288 +285
Lines 186 24695 +24509
Branches 0 2729 +2729
==========================================
+ Hits 154 19148 +18994
- Misses 32 4786 +4754
- Partials 0 761 +761 ☔ View full report in Codecov by Sentry. |
1. Upload a local parquet file to minio s3 bucket 2. Access StructuredDataset attr from a dataclass 3. Open StructuredDataset from a remote path Signed-off-by: JiaWei Jiang <[email protected]>
JiangJiaWei1103
changed the title
[WIP] Add integration test for accessing sd sttr in dc
Add integration test for accessing sd sttr in dc
Dec 22, 2024
Signed-off-by: JiaWei Jiang <[email protected]>
JiangJiaWei1103
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
December 22, 2024 03:06
Signed-off-by: JiaWei Jiang <[email protected]>
Signed-off-by: JiaWei Jiang <[email protected]>
Signed-off-by: JiaWei Jiang <[email protected]>
JiangJiaWei1103
changed the title
Add integration test for accessing sd sttr in dc
[test] Add integration test for accessing sd sttr in dc
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5956
Why are the changes needed?
So far, this patch is tested via single binary, which is limited. The newly released flyte now supports accessing
StructuredDataset
attribute in a dataclass. Hence, we should add an integration to enhance the robustness.What changes were proposed in this pull request?
Add an integration test supporting:
StructuredDataset
attribute from a dataclassStructuredDataset
from a remote path (i.e., the uploaded location)How was this patch tested?
This integration test passes in local run.
Setup process
For local run, the setup process is summarized as follows:
After installation, run the following command:
Screenshots
Check all the applicable boxes
Related PRs
#2954
Docs link