Cherry pick #1732 to release v1.2 branch #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve error handling in ShellTask Signed-off-by: Pradithya Aria <[email protected]> * Add new line Signed-off-by: Pradithya Aria <[email protected]> * Capture stdout Signed-off-by: Pradithya Aria <[email protected]> --------- Signed-off-by: Pradithya Aria <[email protected]> Co-authored-by: Pradithya Aria <[email protected]>
pradithya
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
pradithya
changed the title
|
Can you rebase? #1754 should fix the errors we're seeing in CI. |
…ase-v1.2-cherry-pick
Done! Thanks for looking into it @eapolinario |
pingsutw
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Cherry pick #1732 to release v1.2 branch
Type
Are all requirements met?
Complete description
See #1732
Tracking Issue
flyteorg/flyte#3559
Follow-up issue
NA