Unify dependencies in agent image (#3008) (#3010)

* Install all flyteagent image dependencies in a single command * test - Can I run docker commands in gh workflows? * Remove `-it` flag from `docker run` * Remove quick test after confirming that running `docker run --rm ghcr.io/flyteorg/flyteagent:1.14.0 pyflyte serve agent --port 8000 --timeout 1` in a gh workflow works --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
flyteorg · Dec 17, 2024 · 873cddc · 873cddc
1 parent 7eedc68
commit 873cddc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/pythonpublish.yml b/.github/workflows/pythonpublish.yml
@@ -222,6 +222,9 @@ jobs:
           file: ./Dockerfile.agent
           cache-from: type=gha
           cache-to: type=gha,mode=max
+      - name: Confirm Agent can start
+        run: |
+          docker run --rm ghcr.io/${{ github.repository_owner }}/flyteagent:${{ github.sha }} pyflyte serve agent --port 8000 --timeout 1
       - name: Push flyteagent-all Image to GitHub Registry
         uses: docker/build-push-action@v2
         with:

diff --git a/Dockerfile.agent b/Dockerfile.agent
@@ -8,13 +8,14 @@ ARG VERSION
 RUN apt-get update && apt-get install build-essential -y \
     && pip install uv
 
-RUN uv pip install --system prometheus-client grpcio-health-checking
 RUN uv pip install --system --no-cache-dir -U flytekit==$VERSION \
   flytekitplugins-airflow==$VERSION \
   flytekitplugins-bigquery==$VERSION \
   flytekitplugins-openai==$VERSION \
   flytekitplugins-snowflake==$VERSION \
   flytekitplugins-awssagemaker==$VERSION \
+  prometheus-client \
+  grpcio-health-checking \
   && apt-get clean autoclean \
   && apt-get autoremove --yes \
   && rm -rf /var/lib/{apt,dpkg,cache,log}/ \