Feature: Edit Project Description #5806
Conversation
Signed-off-by: Rob Ulbrich <[email protected]>
# Conflicts: # docker/sandbox-bundled/manifests/complete-agent.yaml # docker/sandbox-bundled/manifests/complete.yaml # docker/sandbox-bundled/manifests/dev.yaml # flyteadmin/pkg/manager/impl/testutils/mock_requests.go # flyteadmin/pkg/manager/impl/validation/execution_validator_test.go # flytepropeller/pkg/compiler/validators/bindings_test.go
# Conflicts: # charts/flyte-core/README.md # deployment/eks/flyte_aws_scheduler_helm_generated.yaml # deployment/eks/flyte_helm_controlplane_generated.yaml # deployment/eks/flyte_helm_generated.yaml # deployment/gcp/flyte_helm_controlplane_generated.yaml # deployment/gcp/flyte_helm_generated.yaml # deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml # deployment/sandbox/flyte_helm_generated.yaml
Signed-off-by: Ulbrich Robert <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5806 +/- ##
==========================================
- Coverage 36.31% 36.31% -0.01%
==========================================
Files 1304 1304
Lines 110072 110085 +13
==========================================
+ Hits 39974 39977 +3
- Misses 65936 65946 +10
Partials 4162 4162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Again a question from my side: I have edited some lines of code that never had any test. now I am expected to set up some tests. For most of the files it would be not really meaningful to provide an unit test. Is there a way to skip the circumvent the code coverage check? |
| @@ -43,11 +43,6 @@ flyteadmin: | |||
| memory: 50Mi | |||
| # -- Default regex string for searching configuration files | |||
| configPath: /etc/flyte/config/*.yaml | |||
| # -- Initial projects to create | |||
There was a problem hiding this comment.
Won't this break backwards compatibility with old values files?
There was a problem hiding this comment.
If a user updates the HELM chart and the values set for the customer remain, it will not do any harm, because the projects were already created before. Projects created once are not deleted, if they do not show up on this list.
So only if the user wants to create new projects, he or she needs to adapt the new values for the initial projects
|
Thius merge request can be closed as there is another pull request that solved it: #5864 |
|
@robert-ulbrich-mercedes-benz thank you! |
Why are the changes needed?
This change allows to set the description of a Flyte project. It could hold the responsible team for a Flyte project including the contact data or some other information.
What changes were proposed in this pull request?
flyte-coreHelm chart so they can hold a name and a description for the projectflyte-binaryand the single binary approach the structure of the Helm chart was changedHow was this patch tested?
flyteadmin migrate seed-projectswas tested with the adaptedflyte-single-binary-local.yamlconfig fileSetup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
The program was tested solely for our own use cases, which might differ from yours
Robert Ulbrich [email protected], Mercedes-Benz Tech Innovation GmbH, legal info/Impressum