-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable caching in flyte-core helmchart #5739
Enable caching in flyte-core helmchart #5739
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
For DCO I'm waiting for our legal department so this might take a bit for the first contribution. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5739 +/- ##
=========================================
Coverage ? 36.29%
=========================================
Files ? 1305
Lines ? 109997
Branches ? 0
=========================================
Hits ? 39927
Misses ? 65914
Partials ? 4156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4b112df
to
bd85939
Compare
DCO should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for fixing it
@cpaulik Thank so much! Also to fix the problem detected by generate_helm, you should be able to run |
Signed-off-by: Christoph Paulik <[email protected]>
bd85939
to
b8d7f7b
Compare
I ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
…mchart Signed-off-by: Eduardo Apolinario <[email protected]>
Congrats on merging your first pull request! 🎉 |
Why are the changes needed?
Without this caching was actually not enabled when deploying with the flyte-core helm chart
What changes were proposed in this pull request?
Adding
storage
to thecache.yaml
file so that the configuration values forstorage.cache.max_size_mbs
andstorage.cache.target_gc_percet
are picked up correctlyHow was this patch tested?
I've deployed flyte core without this change and caching was not enabled. After I added
caching started working so I assume that adding
storage
in thecache.yaml
would also work.