Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mermaid diagrams rendering issue #5373

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidmirror-ops
Copy link
Contributor

Tracking issue

Closes #4864

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: davidmirror-ops <[email protected]>
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.23%. Comparing base (fd42f65) to head (4bd87f9).
Report is 546 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5373      +/-   ##
==========================================
+ Coverage   58.99%   60.23%   +1.23%     
==========================================
  Files         645      646       +1     
  Lines       55542    45664    -9878     
==========================================
- Hits        32769    27505    -5264     
+ Misses      20182    15569    -4613     
+ Partials     2591     2590       -1     
Flag Coverage Δ
unittests ?
unittests-datacatalog 69.31% <ø> (?)
unittests-flyteadmin 58.90% <ø> (?)
unittests-flytecopilot 17.79% <ø> (?)
unittests-flyteidl 79.30% <ø> (?)
unittests-flyteplugins 61.94% <ø> (?)
unittests-flytepropeller 57.32% <ø> (?)
unittests-flytestdlib 65.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: davidmirror-ops <[email protected]>
@neverett
Copy link
Contributor

@davidmirror-ops I got mermaid diagrams to render locally with mermaid_output_format = "png" plus npm installing mermaid-cli with npm install -g @mermaid-js/mermaid-cli. I'm not sure how to get that installed on the build server, though—@cosmicBboy do you know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Mermaid diagrams not rendering
2 participants