Add option to install CRD as a part of chart install in flyte-binary …

…-- PR suggestions Signed-off-by: marrrcin <[email protected]>
flyteorg · Nov 6, 2024 · ff9ae23 · ff9ae23
1 parent 66f839c
commit ff9ae23
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/charts/flyte-binary/templates/configmap.yaml b/charts/flyte-binary/templates/configmap.yaml
@@ -40,7 +40,7 @@ data:
       show-source: true
       level: {{ default 1 .Values.configuration.logging.level }}
     propeller:
-      create-flyteworkflow-crd: {{ .Values.configuration.propeller.createCrd }}
+      create-flyteworkflow-crd: {{ .Values.configuration.propeller.createCRDs }}
     webhook:
       certDir: /var/run/flyte/certs
       localCert: true

diff --git a/charts/flyte-binary/templates/crds/flyteworkflow.yaml b/charts/flyte-binary/templates/crds/flyteworkflow.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.crds.create }}
+{{- if not .Values.configuration.propeller.createCRDs }}
 {{- if $.Capabilities.APIVersions.Has "apiextensions.k8s.io/v1/CustomResourceDefinition" }}
 apiVersion: apiextensions.k8s.io/v1
 {{- else }}

diff --git a/charts/flyte-binary/values.yaml b/charts/flyte-binary/values.yaml
@@ -178,7 +178,8 @@ configuration:
       defaultTimeout: 10s
   # propeller Specify configuration for Flyte Propeller
   propeller:
-    createCrd: true
+    # createCrd If true, Propeller will install CRDs at runtime, if false, CRDs will be installed during helm install
+    createCRDs: true
   # externalConfigMap Specify an existing, external ConfigMap to use as configuration for Flyte
   # If set, no Flyte configuration will be generated by this chart
   externalConfigMap: ""
@@ -378,10 +379,6 @@ rbac:
   # extraRules Add additional rules to the ClusterRole
   extraRules: []
 
-crds:
-  # create Create CustomResourceDefinition resources during installation
-  create: false
-
 # serviceAccount Configure Flyte ServiceAccount
 serviceAccount:
   # create Create ServiceAccount for Flyte