Expose flag in flyte-binary values file

Signed-off-by: Eduardo Apolinario <[email protected]>
flyteorg · Dec 5, 2024 · 8b888dc · 8b888dc
1 parent 7fd9ec5
commit 8b888dc
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 6 deletions.
diff --git a/charts/flyte-binary/README.md b/charts/flyte-binary/README.md
@@ -64,6 +64,7 @@ Chart for basic single Flyte executable deployment
 | configuration.logging.plugins.stackdriver.enabled | bool | `false` |  |
 | configuration.logging.plugins.stackdriver.templateUri | string | `""` |  |
 | configuration.propeller.createCRDs | bool | `true` |  |
+| configuration.propeller.literalOffloadingConfigEnabled | bool | `true` |  |
 | configuration.storage.metadataContainer | string | `"my-organization-flyte-container"` |  |
 | configuration.storage.provider | string | `"s3"` |  |
 | configuration.storage.providerConfig.azure.account | string | `"storage-account-name"` |  |

diff --git a/charts/flyte-binary/templates/configmap.yaml b/charts/flyte-binary/templates/configmap.yaml
@@ -41,8 +41,10 @@ data:
       level: {{ default 1 .Values.configuration.logging.level }}
     propeller:
       create-flyteworkflow-crd: {{ .Values.configuration.propeller.createCRDs }}
+      {{- if .Values.configuration.propeller.literalOffloadingConfigEnabled }}
       literal-offloading-config:
         enabled: true
+      {{- end}}
     webhook:
       certDir: /var/run/flyte/certs
       localCert: true

diff --git a/charts/flyte-binary/values.yaml b/charts/flyte-binary/values.yaml
@@ -180,6 +180,9 @@ configuration:
   propeller:
     # createCRDs If true, Propeller will install CRDs at runtime, if false, CRDs will be installed during helm install
     createCRDs: true
+    # enableOffloading If true, big literals are offloaded to blob store
+    literalOffloadingConfigEnabled: true
+
   # externalConfigMap Specify an existing, external ConfigMap to use as configuration for Flyte
   # If set, no Flyte configuration will be generated by this chart
   externalConfigMap: ""

diff --git a/docker/sandbox-bundled/manifests/complete-agent.yaml b/docker/sandbox-bundled/manifests/complete-agent.yaml
@@ -823,7 +823,7 @@ type: Opaque
 ---
 apiVersion: v1
 data:
-  haSharedSecret: dG9uSE80VERzZWQxZFJiWQ==
+  haSharedSecret: dWJKZFZBWWtWSGM4ajFZUw==
   proxyPassword: ""
   proxyUsername: ""
 kind: Secret
@@ -1420,7 +1420,7 @@ spec:
     metadata:
       annotations:
         checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
-        checksum/secret: 3998dbad08d57a834584800398f0241a378501b8e3666b4a6a5d3a021f332141
+        checksum/secret: fb07b2b50b56c5acaf388e9b1cc802fc9dc8ed8bcf4b1ffab1423e85f7abc78b
       labels:
         app: docker-registry
         release: flyte-sandbox

diff --git a/docker/sandbox-bundled/manifests/complete.yaml b/docker/sandbox-bundled/manifests/complete.yaml
@@ -805,7 +805,7 @@ type: Opaque
 ---
 apiVersion: v1
 data:
-  haSharedSecret: N1llTHNzSmRuUVNhZzVvTg==
+  haSharedSecret: NTlsaHl4YVdGVmJjcXlkdA==
   proxyPassword: ""
   proxyUsername: ""
 kind: Secret
@@ -1369,7 +1369,7 @@ spec:
     metadata:
       annotations:
         checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
-        checksum/secret: 4000d50d85f9c82b901809737f9fed6bbdf6337661e63f0f5f2376553366b44f
+        checksum/secret: c904d62f5ffb3182576fa85ba6dafc845e40663bff6da7e579c5503b0029e8ea
       labels:
         app: docker-registry
         release: flyte-sandbox

diff --git a/docker/sandbox-bundled/manifests/dev.yaml b/docker/sandbox-bundled/manifests/dev.yaml
@@ -499,7 +499,7 @@ metadata:
 ---
 apiVersion: v1
 data:
-  haSharedSecret: Ym1keGNHTG1QSWRVVXExag==
+  haSharedSecret: bkpOR0xac3FOaWJZMXFTTw==
   proxyPassword: ""
   proxyUsername: ""
 kind: Secret
@@ -934,7 +934,7 @@ spec:
     metadata:
       annotations:
         checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
-        checksum/secret: b95dceebf3d56ec706b2171c52256ff39d3b03378e0400dc779b6da12bc4d09d
+        checksum/secret: 9994f07a562e31de28569ef54dfdd7d6443f2dc0d2d43847d828f84c9d8cafc4
       labels:
         app: docker-registry
         release: flyte-sandbox