increase supervisor buildout and setuptools versions for support for newer python #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elikoga
force-pushed
the
366-update-supervisor-buildout-and-setuptools
branch
2 times, most recently
from
d5680ee
to
fae147e
Compare
|
@elikoga is this still relevant, or was it (maybe) updated otherwise? |
|
This one is part of a larger python 3.10 upgrade thing, so it has stalled a bit |
elikoga
force-pushed
the
366-update-supervisor-buildout-and-setuptools
branch
from
fae147e
to
4d60e7a
Compare
zagy
requested changes
May 28, 2024
| @@ -203,12 +205,13 @@ class Supervisor(Component): | |||
| def configure(self): | |||
| self.provide("supervisor", self) | |||
|
|
|||
| buildout_cfg = File("buildout.cfg", source=self.buildout_cfg) | |||
| buildout_cfg = File("buildout3.cfg", source=self.buildout_cfg) | |||
There was a problem hiding this comment.
I don't see a need to rename the file.
Comment on lines
+172
to
+173
| buildout_version = Attribute(default="3.0.1") | ||
| setuptools_version = Attribute(default="68.0.0") |
There was a problem hiding this comment.
Those versions are passed to buildout but the buildout.cfg doesn't not use them. That is in buildout.cfg the versions are hard-coded. I think that's wrong.
zagy
reviewed
May 28, 2024
| config=buildout_cfg, | ||
| python="3", | ||
| wheel="0.40.0", |
There was a problem hiding this comment.
Maybe we make this configurable like setuptools?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #366