feat(fac): add SFCC monitoring and param output #8657
Merged
+516
−540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracernz
approved these changes
May 24, 2024
Quality Assurance
automation
moved this from 🟡 Code Review: Ready for Review
to 🟣 QA Team Review: Ready to Test
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds a rudimentary FAC SFCC parameter monitoring, and adds the SFCC output parameters on the FAC bus.
This is a prerequisite for the FMGC implementation, as the FMGC use the FACs SFCC data.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
This PR affects the internal logic of the flaps data in the FAC. So, it should be confirmed that the FAC functions (alpha floor, speed scale) work correctly in all slat/flap configs.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.