Update Song with correct MP3 metadata #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the title/artist information of uploaded files isn't accurate when uploading mp3s. The MP3Stat module seems to parse the mp3 correctly, but doesn't update the `artist` and `title` when updating the `duration`, so in some cases the information saved in the database for a song (and displayed in the UI) will be incorrect or poorly formatted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the title/artist information of
uploaded files isn't accurate when uploading mp3s. The MP3Stat module
seems to parse the mp3 correctly, but doesn't update the
artistandtitlewhen updating theduration, so in some cases the informationsaved in the database for a song (and displayed in the UI) will be
incorrect or poorly formatted.
Screenshots of the issue:
Screenshots after the fix locally:
