pass through assign attrs in link#navigate helper #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the keyboard navigation of the Sidebar User Menu wasn't working for anything except the Sign Out link. The issue was the attributes that are passed in to the other menu items (i.e.
role="menuitem"
) were being dropped in the live link helper:Rather than passing along all incoming assigns as attributes, it was extracting just the
class
assign and using that. This PR just updates thatlink/1
function so it works like the otherlink/1
helpers.I'd also like to thank you for putting together a project like this. Invaluable resource for learning the new features of LiveView.