Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an advanced option to skip any Gemfile updates #95

Merged
merged 1 commit into from
May 8, 2024

Conversation

albus522
Copy link
Collaborator

@albus522 albus522 commented May 3, 2024

Motivation

Our standard dockerfile-rails update flow is to bump the gem, run rails generate dockerfile, have it overwrite everything, use the git diff to undo anything we don't want. This is getting really close to not requiring undoing anything, with the Gemfile being a notable exception. For us, we know exactly what we do and don't want in our Gemfile, but we don't have the same level of confidence with the docker interactions, which is what we use this gem for. Particularly annoying at the moment is the insistence that Redis is the only way to run ActionCable.

Generally, I would argue that interacting with the Gemfile at all is beyond the scope of what dockerfile-rails should do, possibly with the exception of checking lock platforms, but I suspect that is likely an uphill battle.

Proposed solution

Add an option to skip modifying the Gemfile. I added the option description to the Readme under the advanced section because it's skipping a significant number of touch points.

I went looking for a place to add tests, but it doesn't appear there are currently tests for any of the Gemfile interactions.

@rubys
Copy link
Collaborator

rubys commented May 3, 2024

Particularly annoying at the moment is the insistence that Redis is the only way to run ActionCable.

That indeed is annoying, and should be fixed. Preferably by scanning Gemfiles and/or config files rather than requiring an option.

Care to take a pass at fixing that? I've invited you to the repository... all I ask is that you maintain the current tests and add new ones when you feel it is appropriate.

@albus522
Copy link
Collaborator Author

albus522 commented May 3, 2024

I have added an issue to track it (#96), but I don't have the spare time to tackle it immediately. I have an inclination that it should be somewhat straight forward to read the ActionCable config, but I've been doing open source long enough to know there are often hidden dragons.

@rubys rubys merged commit 27640b7 into fly-apps:main May 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants