support php 8.4

[fideloper]

No description provided.

[KTanAug21]

Looks great, thank you @fideloper for adding this Pull Request to include PHP 8.4 compatibility!

@rubys can you please check if this can be merged( thank you in advance! )?
Here is how it basically goes:

1. flyctl checks php version from composer.json or the php -v command

2. flyctl calls the dockerfile-laravel and passes the PHP version

3. dockerfile-laravel generates the same Dockerfile and required files needed based on scan

4. The dockerfile generated uses the PHP version identified by flyctl, and uses it to use the proper php config file!

5. I've also run ./vendor/bin/pest locally and everything passes

[fideloper]

Sorry I was premature there. This won't go live to anyone until a release is made, however.

[rubys]

What are the steps for making a release?

[fideloper]

I believe they are

1. make/push a tag
2. make a release from github’s release page within the repo

I use their magic AI button that creates the release notes.

[rubys]

Oh, so unlike Ruby and Node and others that have a separate repository, composer can use github as it's repository. TIL. Sweet!

[fideloper]

yep, it’s registered at “packagist”! https://packagist.org/packages/fly-apps/dockerfile-laravel

…

On Thu, Dec 12, 2024 at 10:20 Sam Ruby ***@***.***> wrote: Oh, so unlike Ruby and Node and others that have a separate repository, composer can use github as it's repository. TIL. Sweet! — Reply to this email directly, view it on GitHub <#45 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSDUY7YXRTEWSVZGPABIL2FGSUPAVCNFSM6AAAAABTJCFJ2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZZGI3DKNBXGM> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>