Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Web support page highlighting in left nav #11424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wrunk
Copy link

@wrunk wrunk commented Nov 21, 2024

The page "Web support for Flutter" wasn't showing an active highlight in the left nav (see screenshots). Looks like there was an extraneous trailing slash.

VERY minor change

Web support for Flutter: No active highlight:
Screenshot 2024-11-21 at 10 08 16

Other pages have:
Screenshot 2024-11-21 at 10 09 00

this section wasn't highlighting when active due to trailing /
@wrunk wrunk requested review from sfshaza2, parlough and a team as code owners November 21, 2024 18:23
Copy link

google-cla bot commented Nov 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sfshaza2
Copy link
Contributor

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit f0a4207):

https://flutter-docs-prod--pr11424-wrunk-web-side-nav-fix-4gx5jldw.web.app

@wrunk
Copy link
Author

wrunk commented Nov 21, 2024

Apologies, my fix was insufficient. For a third level nav item/nav link to get tagged/classed as active, it needs to have 3 path elements (currently only has 2: /platform-integration/web). Options:

  • Move the current platform-integration/web/index.md to something else like platform-integration/web/support.md then add in a TOC-like index.md
  • Change the permalink for the platform-integration/web drop down from /platform-integration/web -> /platform-integration/web/support but this would likely require a redirect for platform-integration/web
  • Something else?

If you let me know your preference I'm happy to update.

@sfshaza2
Copy link
Contributor

@parlough, would you mind owning this one? It looks like some files weren't placed correctly and it's affected the side nav.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants