Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java and Gradle versions in android-java-gradle-migration-guid… #11272

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

KarthiDreamr
Copy link
Contributor

@KarthiDreamr KarthiDreamr commented Oct 14, 2024

Description:
This pull request enhances the android-java-gradle-migration-guide.md file by:

  • Updating it with the latest Java version (21) and its compatible Gradle version (8.5).
  • Including detailed instructions on how to check the JDK version using flutter upgrade and flutter doctor --verbose.

These improvements:

  • Provide a more generalized solution.
  • Make the guide applicable and beneficial for a wider range of developers.
  • Ensure the guide remains relevant and useful for those working on Android projects with Flutter.
  • Offer clear and up-to-date information to help prevent compatibility issues and streamline the setup process.

…e.md

This pull request enhances the android-java-gradle-migration-guide.md file by updating it with the latest Java version (21) and its compatible Gradle version (8.5). The guide now includes detailed instructions on how to check the JDK version using flutter upgrade and flutter doctor --verbose. These improvements are designed to provide a more generalized solution, making it applicable and beneficial for a wider range of developers. By incorporating these updates, we aim to ensure that the guide remains relevant and useful for those working on Android projects with Flutter, offering clear and up-to-date information that can help prevent compatibility issues and streamline the setup process.
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KarthiDreamr, this is great! Thanks for updating the page. We don't really attempt to keep the breaking changes pages up to date but, obviously, this is very useful.

Some images need to be removed and replaced (with the new non-flamingo names), or just renamed. I'm not sure if the old images are still accurate.

I see no point in (yet) running the CI, since it will fail because of the missing images.

Anyway, thanks again and let me know when this PR is ready for another review!


The terminal output for this error is
similar to the following:
![Error dialog in Android Studio: MultipleCompilationErrorsException](/assets/images/docs/releaseguide/android-studio-error.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file does not appear to exist and it's not in this PR.


1. In Android Studio, open the `android` folder.
This should bring up the following dialog:

![Dialog prompting you to upgrade Gradle](/assets/images/docs/releaseguide/android-studio-flamingo-upgrade-alert.png){:width="50%"}
![Dialog prompting you to upgrade Gradle](/assets/images/docs/releaseguide/android-studio-upgrade-alert.png){:width="50%"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image file also does not exist. Either replace the flamingo images with newer, renamed images or rename the flamingo image, whichever is correct. (These are in the repo under /src/content/assets/images/docs/releaseguide/.)


1. Follow the guided workflow to update Gradle.

![Workflow to upgrade Gradle](/assets/images/docs/releaseguide/android-studio-flamingo-gradle-upgrade.png){:width="85%"}
![Workflow to upgrade Gradle](/assets/images/docs/releaseguide/android-studio-gradle-upgrade.png){:width="85%"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto - file isn't there. Also, the "{:width=} was done because the original images overflowed the screen. have you confirmed that this is no longer necessary?

@sfshaza2 sfshaza2 added the review.await-update Awaiting Updates after Edits label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review.await-update Awaiting Updates after Edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants