Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next stable] Update documentation for new location of linux source #11182

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[Next stable] Update documentation for new location of linux source #11182

wants to merge 4 commits into from

Conversation

robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Sep 26, 2024 •
edited by parlough
Loading

The Linux directory was changed in flutter/flutter#153812.

Land once flutter/flutter@8925e1f is in stable.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Sep 26, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 6807f31):

https://flutter-docs-prod--pr11182-linux-runner-dir-wbvj4hjc.web.app

@robert-ancell
Copy link
Contributor Author

I'm not sure if this is required - the windows examples don't seem to mention the runner directory.

@stuartmorgan
Copy link
Contributor

I'm not sure if this is required - the windows examples don't seem to mention the runner directory.

The instructions are IDE-specific. VS doesn't display the source files using the directory hierarchy, so the Windows instructions don't have a path, whereas VS Code does use the hierarchy, so we should.

@parlough parlough changed the title Update documentation for new location of linux source [Next stable] Update documentation for new location of linux source Sep 26, 2024
@parlough parlough marked this pull request as draft September 26, 2024 11:29
parlough
parlough approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

We'll make sure this gets landed once the linked change lands in stable.

@sfshaza2
Copy link
Contributor

@robert-ancell, the PR was merged back in September, but I gather it's not in the stable release yet?

@robert-ancell
Copy link
Contributor Author

@robert-ancell, the PR was merged back in September, but I gather it's not in the stable release yet?

Correct, this is not in stable yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parlough parlough parlough approved these changes

@sfshaza2 sfshaza2 Awaiting requested review from sfshaza2 sfshaza2 is a code owner

@stuartmorgan stuartmorgan Awaiting requested review from stuartmorgan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robert-ancell @flutter-website-bot @stuartmorgan @sfshaza2 @parlough