more on Flutter web indexability #10550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
requested review from
sfshaza2,
atsansone,
parlough,
domesticmouse and
MaryaBelanger
as code owners
|
Visit the preview URL for this PR (updated for commit b204f69): https://flutter-docs-prod--pr10550-more-on-seo-g0uq1szw.web.app |
kevmoo
approved these changes
May 9, 2024
johnpryan
approved these changes
May 9, 2024
atsansone
approved these changes
May 9, 2024
Comment on lines
38
to
41
| Having said that, as we mention in our [roadmap][], we plan to investigate | ||
| search engine indexability of Flutter Web. To that end we've built a small | ||
| website containing [Hawaii-themed space stories][space_hawaii], which we | ||
| would like search engines to pick up and index. |
There was a problem hiding this comment.
suggestion: Would recommend tightening somewhat as the quantity of "we"s is a bit much.
Suggested change
| Having said that, as we mention in our [roadmap][], we plan to investigate | |
| search engine indexability of Flutter Web. To that end we've built a small | |
| website containing [Hawaii-themed space stories][space_hawaii], which we | |
| would like search engines to pick up and index. | |
| That said, as mentioned in the [roadmap][], the Flutter team plans to investigate | |
| search engine indexability of Flutter Web. | |
| To that end, we built a small website containing [Hawaii-themed space stories][space_hawaii]. | |
| We intend for search engines to find and index this site. |
There was a problem hiding this comment.
Further feedback on Tony's feedback:
- It's "Flutter web" NOT "Flutter Web"
- "To that end, we built a small website containing [Hawaii-themed space stories][space_hawaii].
We intend for search engines to find and index this site." =>
To that end, we built a small website containing [Hawaii-themed space stories][space_hawaii],
hoping that search engines find and index this site."
atsansone
added
the
st.RFM.%
sfshaza2
approved these changes
May 9, 2024
Comment on lines
38
to
41
| Having said that, as we mention in our [roadmap][], we plan to investigate | ||
| search engine indexability of Flutter Web. To that end we've built a small | ||
| website containing [Hawaii-themed space stories][space_hawaii], which we | ||
| would like search engines to pick up and index. |
There was a problem hiding this comment.
Further feedback on Tony's feedback:
- It's "Flutter web" NOT "Flutter Web"
- "To that end, we built a small website containing [Hawaii-themed space stories][space_hawaii].
We intend for search engines to find and index this site." =>
To that end, we built a small website containing [Hawaii-themed space stories][space_hawaii],
hoping that search engines find and index this site."
|
Let's hold off on merging this until we can find a solution for b/339684234 |
sfshaza2
changed the title
sfshaza2
removed
the
st.RFM.%
|
Can we get this landed, @yjbanov? |
|
I think we're okay to land now, @sfshaza2 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand on what we're doing about indexability.
One unusual aspect of this change is linking to the test site and spelling out "Hawaii-themed space stories". This is intentional, and hopefully, not too disruptive to the message. In order to prove that SEO works we need an already indexed website to link to the test site so search engines find it and attempt to index it. I thought sneaking one such link into a section of our web FAQ that already talks about SEO would be a safe place for it.
One place I violate the style guide is I use "we" in the text. However, it seems to be consistent with how the word is used elsewhere on the site. I'm open to suggestions for how to remove it, if it's important.
Presubmit checklist