New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive and responsive docs #10305
Adaptive and responsive docs #10305
Conversation
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this include and the build should work fine.
Visit the preview URL for this PR (updated for commit 68ce1e4): https://flutter-docs-prod--pr10305-adaptive-03zbagqg.web.app |
@parlough, as you know, I'm out the rest of the week. But, I would really like these pages to be staged sooner than that. Mariam and the folks giving a talk at I/O need to do some thorough review. If the staging is still failing, can you help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a review of the entire changes
The trick is to balance creating a unique experience with a | ||
strong identity, while respecting the norms of each platform. | ||
|
||
## Common idioms and norms to consider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Shams and everyone else for the hard work on this new content and restructure!!!
I'm approving to unblock dependents of these pages. I'll revisit these new pages to complete a more thorough review of the pages when I have a chance.
I pushed a few rendering, formatting, and spelling fixes. I also scanned the pages, particularly their metadata and header structure, and left a few comments about minor issues. Let me know if you have any questions. Thanks again!
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
Updating the adaptive/responsive docs to make them more complete and more cohesive.
Addresses: #10304
cc: @mariamhas