Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive and responsive docs #10305

Merged
merged 104 commits into from May 13, 2024
Merged

Adaptive and responsive docs #10305

merged 104 commits into from May 13, 2024

Conversation

sfshaza2
Copy link
Contributor

Updating the adaptive/responsive docs to make them more complete and more cohesive.

Addresses: #10304

cc: @mariamhas

@sfshaza2
Copy link
Contributor Author

/gcbrun

Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this include and the build should work fine.

src/ui/layout/responsive/accessibility.md Outdated Show resolved Hide resolved
src/ui/layout/responsive/adaptive-responsive.md Outdated Show resolved Hide resolved
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Mar 18, 2024

Visit the preview URL for this PR (updated for commit 68ce1e4):

https://flutter-docs-prod--pr10305-adaptive-03zbagqg.web.app

@sfshaza2
Copy link
Contributor Author

@parlough, as you know, I'm out the rest of the week. But, I would really like these pages to be staged sooner than that. Mariam and the folks giving a talk at I/O need to do some thorough review. If the staging is still failing, can you help?

src/ui/adaptive-responsive/layout.md Outdated Show resolved Hide resolved
src/ui/adaptive-responsive/layout.md Outdated Show resolved Hide resolved
src/ui/adaptive-responsive/layout.md Outdated Show resolved Hide resolved
src/ui/adaptive-responsive/layout.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mariamhas mariamhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a review of the entire changes

src/content/ui/adaptive-responsive/large-screens.md Outdated Show resolved Hide resolved
src/content/ui/adaptive-responsive/large-screens.md Outdated Show resolved Hide resolved
src/content/ui/adaptive-responsive/large-screens.md Outdated Show resolved Hide resolved
src/content/ui/adaptive-responsive/large-screens.md Outdated Show resolved Hide resolved
src/content/ui/adaptive-responsive/large-screens.md Outdated Show resolved Hide resolved
src/content/ui/adaptive-responsive/large-screens.md Outdated Show resolved Hide resolved
src/content/ui/adaptive-responsive/best-practices.md Outdated Show resolved Hide resolved
The trick is to balance creating a unique experience with a
strong identity, while respecting the norms of each platform.

## Common idioms and norms to consider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@sfshaza2 sfshaza2 marked this pull request as ready for review May 11, 2024 19:12
@parlough parlough requested a review from mariamhas May 13, 2024 00:27
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shams and everyone else for the hard work on this new content and restructure!!!

I'm approving to unblock dependents of these pages. I'll revisit these new pages to complete a more thorough review of the pages when I have a chance.

I pushed a few rendering, formatting, and spelling fixes. I also scanned the pages, particularly their metadata and header structure, and left a few comments about minor issues. Let me know if you have any questions. Thanks again!

src/content/ui/adaptive-responsive/best-practices.md Outdated Show resolved Hide resolved
src/content/ui/adaptive-responsive/index.md Outdated Show resolved Hide resolved
src/content/ui/adaptive-responsive/index.md Outdated Show resolved Hide resolved
src/content/ui/adaptive-responsive/input.md Show resolved Hide resolved
src/content/ui/adaptive-responsive/best-practices.md Outdated Show resolved Hide resolved
src/content/ui/adaptive-responsive/safearea-mediaquery.md Outdated Show resolved Hide resolved
src/content/ui/layout/responsive/building-adaptive-apps.md Outdated Show resolved Hide resolved
@sfshaza2 sfshaza2 dismissed mariamhas’s stale review May 13, 2024 01:08

I've incorporated her changes.

@sfshaza2 sfshaza2 merged commit ec441c7 into main May 13, 2024
9 checks passed
@sfshaza2 sfshaza2 deleted the adaptive branch May 13, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet