Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart fix --apply from Flutter 3.21.0-1.0.pre.2 #2220

Closed

Conversation

domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented Mar 21, 2024

Hey @QuncCccccc, any views on the fixes suggested by dart fix?

This PR needs to be held for the next stable update.

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@domesticmouse domesticmouse marked this pull request as draft March 21, 2024 09:23
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. I was OOO last week. LGTM! For the deprecated colors, I think we can just remove the corresponding ColorChips. Leaving them here for now is also okay because I will update this ColorScheme page soon to add all the new colors and remove the deprecated colors (If they are still here:)).

@@ -303,13 +303,13 @@ class ColorSchemeView extends StatelessWidget {
children: [
ColorChip(
label: 'background',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can actually remove these chips whose colors have been deprecated:)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to adopt this change and adapt it to suit your needs. I was just getting in early to see what the required changes for the next stable release might look like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed a small change to remove the deprecated color chips! :)

@@ -251,13 +251,13 @@ class ColorSchemeView extends StatelessWidget {
),
ColorChip(
label: 'surfaceVariant',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, I think we can remove this:)

@domesticmouse domesticmouse marked this pull request as ready for review April 28, 2024 23:14
@domesticmouse
Copy link
Contributor Author

Replaced by #2266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants