New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify M3 demo sample issues, determine source of each, and file relevant issues #2129
Comments
Hi all! I've gone through the Material 3 demo sample to find various issues, then determine if they are caused by You can find each of these issues above organized within those categories. Each issue has a link to the corresponding Flutter or Dart issue(s) I filed for them, as well as to the relevant fix if that's been made. \cc @kevmoo For awareness about the various skwasm issues. As for Thanks! |
@parlough – you rock SOOO MUCH 🤘 |
I'm going to be using this issue to find and track issues with the sample, then determine if they're caused by wasm compilation, skwasm, the sample itself, browser support, or Flutter. If an issue is not open for any issues found, I will open one in the appropriate repository and link to it from here.
Code: https://github.com/flutter/samples/tree/main/material_3_demo
Version: HEAD on
main
Staged: https://parlough-testing-skwasm.web.app/
Determined issues
Wasm build
These issues happen with
flutter build web --wasm
(using CanvasKit).DateTime.timeZoneOffset
has the wrong sign dart-lang/sdk#54448skwasm
rendererThese issues happen with
flutter build web --wasm --web-renderer=skwasm
.ColorScheme.fromImageProvider
always produces the same result flutter#141326ActionChip
and disabledInputChip
aren't rendering their contentsActionChip
with label and avatar fails to render contents flutter#140999InputChip
is improperly locatedInputChip
delete icon hover square is not centered flutter#141000Flutter (framework or engine)
I determined these issues affect all Flutter backends, at least web and desktop.
InputChip
has square background on hover inconsistent with ink splash.InputChip
shows delete even though it's not interactableonDeleted
callback shows "Delete" tooltip on hover flutter#141336DatePickerDialog
"Switch to input" button has no margin from dialog side flutter#141338DatePickerDialog
has unnecessary scrollbar on months with 6 rows flutter#141348DatePickerDialog
date entry hover background and ink splash have different radius flutter#141350ProgressIndicator
for Material 3 redesign flutter#141340SnackBar
"Close" text hover surface is (almost) impossible to see in light and dark themesSnackBar
action hover state background too hard to see flutter#141343TextField
styles result in cursor overlappinglabelText
flutter#141354SearchAnchor
search view clear button shows up even if you haven't entered any text flutter#141346SearchAnchor
search view close and clear buttons don't have hover tooltips flutter#141347SearchAnchor.bar
loses focus flutter#141395showBottomSheet
should have ashowDragHandle
option likeshowModalBottomSheet
flutter#141353AppBar
back button focus/hover circle should not fill up whole height flutter#141361Sample
I determined these issues are likely because of the sample itself.
Browser(s)
Undetermined issues
Not sure
Uncaught TypeError: Cannot read properties of null (reading 'ds'...
Sample or Flutter
I determined these issues impact the sample whether running with Wasm or not. I still need to determine if they are because of Flutter or because of the sample.
The text was updated successfully, but these errors were encountered: