Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web-specific issues with "Material 3 - Flutter WasmGC Preview" #2069

Closed
tomayac opened this issue Oct 26, 2023 · 10 comments
Closed

Web-specific issues with "Material 3 - Flutter WasmGC Preview" #2069

tomayac opened this issue Oct 26, 2023 · 10 comments
Assignees
Labels

Comments

@tomayac
Copy link

tomayac commented Oct 26, 2023

Tested on 120.0.6089.3 (Official Build) canary (arm64).

@parlough
Copy link
Member

Thanks for the videos showcasing the issues!

Just to confirm, did you access the sample at https://flutterweb-wasm.web.app/, somewhere your else, or build it yourself with a recent Flutter build? On Chrome 120 I'm only able to get the WASM sample running by building myself with the latest Flutter main builds.

I think outside of the text editing issues, these issues exist in some form on the JS version of the demo too. \cc @QuncCccccc

I can't seem to reproduce the text editing issues on the JS version nor by building myself on the latest main on Version 120.0.6090.1 (Official Build) canary (arm64).

\cc @kevmoo

@tomayac
Copy link
Author

tomayac commented Oct 26, 2023

This was tested with the URL you can find in this Google Doc. Please ask for access, since it's not yet public.

@kevmoo
Copy link
Contributor

kevmoo commented Oct 26, 2023

We should compare with https://flutter.github.io/samples/web/material_3_demo/

To see if these are issues with the Wasm work, or just issues with the demo/widgets!

@parlough
Copy link
Member

parlough commented Oct 26, 2023

Thanks for the link! Clarifying for the issue that these videos are with skwasm.

I can reproduce the scrolling and tabbing issues with the original JS version.

The popover behavior does seem to have more issues in the linked version and the text editing issues are unique to this version as well. They don't occur on a wasm build with CanvasKit either.

@tomayac
Copy link
Author

tomayac commented Oct 26, 2023

All videos and reported issues stem from the version linked in the Google Doc experienced in 120.0.6089.3 (Official Build) canary (arm64).

@domesticmouse
Copy link
Contributor

Who should I assign this issue to?

@kevmoo
Copy link
Contributor

kevmoo commented Nov 1, 2023

@domesticmouse – we need to figure out if this is a widget issue or a flutter wasm issue.

So...I'm not sure. It'd be great to have our flutter/flutter triage person take a stab.

@QuncCccccc
Copy link
Contributor

QuncCccccc commented Nov 1, 2023

Hi!

The scrolling behavior is intended. We compute the scroll bar height when more content shows up for the first time and cache the height. So after that, the scroll bar height should be fixed!

I can reproduce the popover positioning problem. I think it's a widget issue. I will take a look:) !

For the other two issues, I cannot reproduce them.

@domesticmouse
Copy link
Contributor

@kevmoo assigning this to you to chase down the issues @QuncCccccc can't repro

@parlough
Copy link
Member

Closing in favor of #2129, where I'm tracking this and other issues more specifically. Thanks all!

@parlough parlough closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants