-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web-specific issues with "Material 3 - Flutter WasmGC Preview" #2069
Comments
Thanks for the videos showcasing the issues! Just to confirm, did you access the sample at https://flutterweb-wasm.web.app/, somewhere your else, or build it yourself with a recent Flutter build? On Chrome 120 I'm only able to get the WASM sample running by building myself with the latest Flutter I think outside of the text editing issues, these issues exist in some form on the JS version of the demo too. \cc @QuncCccccc I can't seem to reproduce the text editing issues on the JS version nor by building myself on the latest \cc @kevmoo |
This was tested with the URL you can find in this Google Doc. Please ask for access, since it's not yet public. |
We should compare with https://flutter.github.io/samples/web/material_3_demo/ To see if these are issues with the Wasm work, or just issues with the demo/widgets! |
Thanks for the link! Clarifying for the issue that these videos are with skwasm. I can reproduce the scrolling and tabbing issues with the original JS version. The popover behavior does seem to have more issues in the linked version and the text editing issues are unique to this version as well. They don't occur on a wasm build with CanvasKit either. |
All videos and reported issues stem from the version linked in the Google Doc experienced in |
Who should I assign this issue to? |
@domesticmouse – we need to figure out if this is a widget issue or a flutter wasm issue. So...I'm not sure. It'd be great to have our flutter/flutter triage person take a stab. |
Hi! The scrolling behavior is intended. We compute the scroll bar height when more content shows up for the first time and cache the height. So after that, the scroll bar height should be fixed! I can reproduce the popover positioning problem. I think it's a widget issue. I will take a look:) ! For the other two issues, I cannot reproduce them. |
@kevmoo assigning this to you to chase down the issues @QuncCccccc can't repro |
Closing in favor of #2129, where I'm tracking this and other issues more specifically. Thanks all! |
Tested on
120.0.6089.3 (Official Build) canary (arm64)
.https://github.com/flutter/samples/assets/145676/d0a2146a-520b-4f71-951f-a86b6ee770ef
https://github.com/flutter/samples/assets/145676/578bd859-1376-4017-a8a8-78d687fed1b1
https://github.com/flutter/samples/assets/145676/87e25d9a-4fe3-4669-b8eb-9a3f45f6cb2b
https://github.com/flutter/samples/assets/145676/a3c384b9-16d1-4688-8558-a9be825a825e
https://github.com/flutter/samples/assets/145676/e7401cf5-ccb8-486d-a105-dd090cec6594
The text was updated successfully, but these errors were encountered: