Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[url_launcher_windows] Correct logging url #8107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anayw2001
Copy link

@anayw2001 anayw2001 commented Nov 15, 2024

This CL fixes the URL being logged to be unescaped one if applicable instead of the original input URL.

Fixes #159009

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan
Copy link
Contributor

Thanks for the contribution! You’ve checked boxes in the PR checklist above that are not reflected in this PR, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when the checklist reflects the state of the PR as posted please feel free to mark it as ready for review.

Please make sure to complete this step as well, so that it's clear what the problem you are trying to solve is. It's not currently clear what the motivation for this change is.

@stuartmorgan stuartmorgan marked this pull request as draft November 15, 2024 18:58
@stuartmorgan stuartmorgan removed the request for review from cbracken November 15, 2024 18:59
@anayw2001 anayw2001 marked this pull request as ready for review November 15, 2024 22:55
@stuartmorgan
Copy link
Contributor

stuartmorgan commented Nov 15, 2024

What are the documented version, changelog, and test exemption reasons that this PR falls under?

@anayw2001 anayw2001 marked this pull request as draft November 16, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[url_launcher] URL logged on error is wrong on Windows
2 participants