Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[image_picker_macos] macOS native image picker #8079

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[image_picker_macos] macOS native image picker #8079

wants to merge 12 commits into from

Commits on Nov 17, 2024

  1. chore(example): update outdated macOS example using Flutter CLI (auto… 

    …mated), deprecated @NSApplicationMain attribute

Signed-off-by: Ellet <[email protected]>
    @EchoEllet
    EchoEllet committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    0937fca View commit details
    Browse the repository at this point in the history

  2. feat(macos): (WIP) adds support for macOS PHPicker for image_picker_m… 

    …acos

- Updates the `image_picke_macos`'s `pubspec.yaml` to add `pigeon` as dev dependency and add the `pluginClass` for Swift native code
- Adds the `ImagePickerPlugin` in `image_picker_macos/macos` for native macOS plugin with support for SPM and CocoaPods with basic native unit tests
- Uses the steps in https://github.com/flutter/flutter/blob/master/docs/ecosystem/testing/Plugin-Tests.md#enabling-xctests-or-xcuitests to enable `XCTests` and `XCUITests`
- Updates the `image_picker_macos_test.dart` to fix the test failure and ensure PHPicker is disabled by default
- Adds a new button in the example to enable/disable PHPicker macOS implementation and enable the PHPicker by default
- Updates the `README.md` of `image_picker_macos` and `image_picker` to document the usage
- Removes two TODOs in `image_picker_macos.dart` as they are done with this PR
- Adds TODOs that need to be done before merging the PR, some of them are questions, will be removed
- Implement the getMultiImageWithOptions() since the getMultiImage is deprecated, updates getMultiImage() to delegate to getMultiImageWithOptions() since getMultiImageWithOptions() is required to access the limit property
- Updates the Dart unit tests of image_picker_macos
- Adds simple integration test for the example
- Updates `pubspec.yaml` and `CHANGELOG.md` of `image_picker` and `image_picker_macos`

Signed-off-by: Ellet <[email protected]>
    @EchoEllet
    EchoEllet committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    0a36d31 View commit details
    Browse the repository at this point in the history

  3. chore: generate pigeons and mocks with the latest dev dependencies 

    Signed-off-by: Ellet <[email protected]>
    @EchoEllet
    EchoEllet committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    1781a73 View commit details
    Browse the repository at this point in the history

  4. chore: format Swift generated file Messages.g.swift 

    Signed-off-by: Ellet <[email protected]>
    @EchoEllet
    EchoEllet committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    5465142 View commit details
    Browse the repository at this point in the history

  5. chore: restore backticks of file_selector link 

    Signed-off-by: Ellet <[email protected]>
    @EchoEllet
    EchoEllet committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    ce49360 View commit details
    Browse the repository at this point in the history

  6. chore: update supported macOS version from 10.11 to 10.14 for image_p… 

    …icker_macos plugin

Signed-off-by: Ellet <[email protected]>
    @EchoEllet
    EchoEllet committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    e0c7e3a View commit details
    Browse the repository at this point in the history

  7. chore: use getVideo() instead of the soft-deprecated pickVideo() in u… 

    …nit test for consistency

Signed-off-by: Ellet <[email protected]>
    @EchoEllet
    EchoEllet committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    8d8eef9 View commit details
    Browse the repository at this point in the history

  8. chore: update outdated TODOs as they moved to flutter#8079 

    Signed-off-by: Ellet <[email protected]>
    @EchoEllet
    EchoEllet committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    60035a2 View commit details
    Browse the repository at this point in the history

  9. test: add minor test for pickVideo 

    Signed-off-by: Ellet <[email protected]>
    @EchoEllet
    EchoEllet committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    eeb3f4c View commit details
    Browse the repository at this point in the history

  10. chore: run dart format for Dart generated files 

    Signed-off-by: Ellet <[email protected]>
    @EchoEllet
    EchoEllet committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    a123470 View commit details
    Browse the repository at this point in the history

  11. chore: 'try' precede 'await' in ImagePickerImpl.swift 

    Signed-off-by: Ellet <[email protected]>
    @EchoEllet
    EchoEllet committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    ce6aed8 View commit details
    Browse the repository at this point in the history

  12. chore: hardcode the supportsPHPicker() name to fix CI warnings 

    Signed-off-by: Ellet <[email protected]>
    @EchoEllet
    EchoEllet committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    c9122f9 View commit details
    Browse the repository at this point in the history