Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_maps_flutter] Ground Overlay support for Android and iOS #7052

Closed
wants to merge 5 commits into from

Conversation

gabbopalma
Copy link

This Pull Request should solve the lack of integration of Ground Overlays type objects within iOS and Android maps, on Flutter.
Within the commits I worked on the Dart, Java and Objective-C code integrating the new geometry and aligning the code with the SDKs to which the device belongs (iOS or Android).
In the past, this important type of geometry was not supported in any way by the Flutter package of Google Maps. I think it is essential to have GroundOverlays on Flutter as well, so I decided to work on it and attempt integration.
The only gap of the current changes I have made is that the "fromPosition" constructor type does not work on iOS. But, in contrast, the "fromBounds" constructor works correctly.
Constructive and helpful comments are welcome to improve the implementation and finally make GroundOverlay available to all developers who appreciate Google Maps.

Linked to 26479 issue.

Changes made:

  • google_maps_flutter:
    • Added methods related to GroundOverlays (such as updateGroundOverlays, onGroundOverlayTap etc.) and adapted existing code;
    • Added tests on GroundOverlays to the examples folder;
    • Pubspec.yaml and changelog updated.
  • google_maps_flutter_android:
    • Added GroundOverlays classes and its related code into the existing Java code;
    • Added test cases on GroundOverlays in the Java code;
    • Added the test cases on the GroundOverlays in the examples folder;
    • Pubspec.yaml and changelog updated.
  • google_maps_flutter_ios:
    • Added GroundOverlays classes and its related code into the existing Objective-C code;
    • Add tests on GroundOverlays in the examples folder;
    • Pubspec.yaml and changelog updated.
  • google_maps_flutter_platform_interface:
    • Added classes and methods related to GroundOverlays;
    • Added tests on GroundOverlays to the test folder;
    • Pubspec.yaml and changelog updated.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@goderbauer
Copy link
Member

(triage) @gabbopalma Do you still have plans to finish this PR and take it out of draft mode?

@gabbopalma
Copy link
Author

I will work on this on the next weeks. Actually, I have just to align the edits to the latest commits.

@chunhtai
Copy link
Contributor

Closing this as inactive, feel free to reopen once you have time to come back to this pr

@chunhtai chunhtai closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants