[go_router] Fixes issue that path parameters are not set when using t… #6698
+55
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangyujin
reviewed
May 10, 2024
| return _router.configuration.locationForRoute(route)!; | ||
| final List<String> parameters = <String>[]; | ||
| patternToRegExp(route.path, parameters); | ||
| assert( |
There was a problem hiding this comment.
Add test for this assertion case too?
There was a problem hiding this comment.
It looks like the route constructor already asserted this. so this assert is not reachable. I removed the comment since and treated it as a sanity check since it is no longer user facing check
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 20, 2024
flutter/packages@ae4dd32...ba19b24 2024-05-19 [email protected] Roll Flutter from 00425ef to adf279f (13 revisions) (flutter/packages#6761) 2024-05-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.4 to 4.1.6 (flutter/packages#6751) 2024-05-17 [email protected] [go_router] Fixes issue that path parameters are not set when using t� (flutter/packages#6698) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he goBranch.
fixes flutter/flutter#129878
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.