[google_maps_flutter_platform_interface] Add improvements to BitmapDescriptor API #6687
+1,050
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jokerttu
force-pushed
the
feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements
branch
from
04e97b8
to
c7a56e4
Compare
jokerttu
force-pushed
the
feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements
branch
2 times, most recently
from
937a3ee
to
8fa54ff
Compare
- Improves public api for width and height values of the MapBitmap - Also includes small fix to test naming.
jokerttu
force-pushed
the
feature/google_maps_flutter_platform_interface_bitmapdescriptor_improvements
branch
from
8fa54ff
to
2970bbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds improvements to BitmapDescriptor API for google_maps_flutter_platform_interface
AssetMapBitmapandBytesMapBitmap.BitmapDescriptor.fromAssetImagein favor ofBitmapDescriptor.assetandAssetMapBitmap.create.BitmapDescriptor.fromBytesin favor ofBitmapDescriptor.bytesandBytesMapBitmapThis is prequel PR for: #4055
Containing only changes to
google_maps_flutter_platform_interfacepackage.Follow up PR:s will hold the platform and app-facing plugin implementations.
Linked issue: flutter/flutter#34657
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.