Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router] docs: updated link in navigation.md to correct file path for push_with_shell_route.dart #6670

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

altynbek132
Copy link

@altynbek132 altynbek132 commented May 6, 2024

[go_router] docs: updated link in navigation.md to correct file path for push_with_shell_route.dart

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update version and change log so that this can be published to pub dev?

@altynbek132 altynbek132 force-pushed the pr_url_fix branch 2 times, most recently from 84868a0 to 0505d5c Compare May 10, 2024 19:50
@altynbek132
Copy link
Author

Can you update version and change log so that this can be published to pub dev?

@chunhtai done

@Ankit-Kumar-Dhangar1
Copy link

i am using gorouter with bottomnavigation
quickaction is working fine for first time but when i change tab ,close it , and open it again using quickaction it is not opening to set page.

@altynbek132 altynbek132 requested a review from chunhtai May 11, 2024 09:55
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you rebase again? this package has a lot of traffic

@chunhtai chunhtai requested a review from hangyujin May 16, 2024 21:36
@altynbek132
Copy link
Author

@chunhtai rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants