Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create abstract layer for deep_link_client to simplify other implementations #1158

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

elianortega
Copy link
Contributor

Description

With the Firebase dynamic link deprecation, the template DeepLinkClient should expose an abstract class that enables easy implementation of the deep link service with another package.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@elianortega
Copy link
Contributor Author

If there is any feedback regarding the naming of the DeepLinkService and the updated folder structure for deep_link_client/, please let me know 🙌

I also ran all the workflows on this PR from my repo.

Finally, what are your thought on providing another implementation of the DeepLinkService? Dynamic links are on their way to be deprecated so I think that providing another implementation using package:app_links or package:uni_links could be a greate addition to the template.

@matiasleyba
Copy link
Contributor

matiasleyba commented Mar 26, 2024

If there is any feedback regarding the naming of the DeepLinkService and the updated folder structure for deep_link_client/, please let me know 🙌

I also ran all the workflows on this PR from my repo.

Finally, what are your thought on providing another implementation of the DeepLinkService? Dynamic links are on their way to be deprecated so I think that providing another implementation using package:app_links or package:uni_links could be a greate addition to the template.

If there is any feedback regarding the naming of the DeepLinkService and the updated folder structure for deep_link_client/, please let me know 🙌

I also ran all the workflows on this PR from my repo.

Finally, what are your thought on providing another implementation of the DeepLinkService? Dynamic links are on their way to be deprecated so I think that providing another implementation using package:app_links or package:uni_links could be a greate addition to the template.

@elianortega I agree that adding a new implementation of deeplinking would be great 👍🏻

app_links seems to be one of the best packages out there and meets the toolkit requirements.
uni_links seems abandoned, I wouldn't use it.

Remember to keep an eye on the package configuration, as we should configure both Android and iOS platforms in the template and also document any necessary configuration needed.

@elianortega
Copy link
Contributor Author

elianortega commented Mar 28, 2024

@elianortega I agree that adding a new implementation of deeplinking would be great 👍🏻

app_links seems to be one of the best packages out there and meets the toolkit requirements. uni_links seems abandoned, I wouldn't use it.

Remember to keep an eye on the package configuration, as we should configure both Android and iOS platforms in the template and also document any necessary configuration needed.

@matiasleyba Yes, I'll send that to another PR after this one gets merged 👍

Copy link
Contributor

@matiasleyba matiasleyba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elianortega Thanks for addressing the comments, the changes look good! Anyway I would like to hold the merge until we solve a issue we are having with the CI workflows.
Once we solve the issue we will be able to merge the PR, I will keep you posted on the issue.

@elianortega
Copy link
Contributor Author

No worries @matiasleyba, let me know if I can help with anything 👍

@matiasleyba
Copy link
Contributor

Hi @elianortega, we have been able to resolve the issues with the CI workflows, would you mind updating the PR? Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants