New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create abstract layer for deep_link_client to simplify other implementations #1158
base: main
Are you sure you want to change the base?
Conversation
If there is any feedback regarding the naming of the I also ran all the workflows on this PR from my repo. Finally, what are your thought on providing another implementation of the |
flutter_news_example/packages/deep_link_client/deep_link_client/pubspec.yaml
Outdated
Show resolved
Hide resolved
flutter_news_example/packages/deep_link_client/deep_link_client/lib/src/deep_link_client.dart
Outdated
Show resolved
Hide resolved
flutter_news_example/packages/deep_link_client/deep_link_client/lib/src/deep_link_client.dart
Outdated
Show resolved
Hide resolved
flutter_news_example/packages/deep_link_client/deep_link_client/lib/src/deep_link_service.dart
Outdated
Show resolved
Hide resolved
flutter_news_example/packages/deep_link_client/deep_link_client/test/deep_link_client_test.dart
Outdated
Show resolved
Hide resolved
...packages/deep_link_client/firebase_deep_link_service/lib/src/firebase_deep_link_service.dart
Outdated
Show resolved
Hide resolved
...packages/deep_link_client/firebase_deep_link_service/lib/src/firebase_deep_link_service.dart
Outdated
Show resolved
Hide resolved
...ckages/deep_link_client/firebase_deep_link_service/test/firebase_deep_link_service_test.dart
Outdated
Show resolved
Hide resolved
@elianortega I agree that adding a new implementation of deeplinking would be great 👍🏻
Remember to keep an eye on the package configuration, as we should configure both Android and iOS platforms in the template and also document any necessary configuration needed. |
@matiasleyba Yes, I'll send that to another PR after this one gets merged 👍 |
flutter_news_example/packages/deep_link_client/deep_link_client/lib/src/deep_link_service.dart
Outdated
Show resolved
Hide resolved
flutter_news_example/packages/deep_link_client/deep_link_client/lib/src/deep_link_client.dart
Outdated
Show resolved
Hide resolved
...e/packages/deep_link_client/firebase_deep_link_client/lib/src/firebase_deep_link_client.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elianortega Thanks for addressing the comments, the changes look good! Anyway I would like to hold the merge until we solve a issue we are having with the CI workflows.
Once we solve the issue we will be able to merge the PR, I will keep you posted on the issue.
No worries @matiasleyba, let me know if I can help with anything 👍 |
Hi @elianortega, we have been able to resolve the issues with the CI workflows, would you mind updating the PR? Thanks in advance! |
Description
With the Firebase dynamic link deprecation, the template
DeepLinkClient
should expose an abstract class that enables easy implementation of the deep link service with another package.Type of Change