Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT LAND: But I'm really curious to see if anything blows up #56766

Draft
wants to merge 104 commits into
base: main
Choose a base branch
from

Conversation

cbracken
Copy link
Member

THIS IS A WORK IN PROGRESS CLEANUP -- DO NOT LAND.

Mostly just seeing if anything I haven't tested locally gets upset.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken cbracken marked this pull request as draft November 22, 2024 23:12
@cbracken cbracken force-pushed the objc-platformviews-controller branch 6 times, most recently from fefa536 to d8944f4 Compare November 23, 2024 23:17
@cbracken cbracken force-pushed the objc-platformviews-controller branch from d8944f4 to 9184dbb Compare November 23, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant