Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions of agp and robolectric, and configure to use SDK 35 #56732

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Nov 20, 2024

Bumps the version of AGP used in the IDE-support build.gradle, as well as the robolectric version in both the IDE-support build.gradle and test-runner-build.gradle.

This is the current latest robolectric: https://github.com/robolectric/robolectric/releases/tag/robolectric-4.14.1.

Also

  1. configures robolectric to use API 35, and
  2. removes the use of a deprecated class which (from what I could tell) looked like it was just used for setup, and the test still passes without it.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall changed the title Bump versions of agp and robolectric Bump versions of agp and robolectric, and configure to use SDK 35 Nov 21, 2024
@gmackall gmackall marked this pull request as ready for review November 21, 2024 22:17
@gmackall
Copy link
Member Author

cc @utzcoz, just because I've seen you make robolectric related contributions here (no actions needed but any thoughts welcome!)

@gmackall gmackall requested a review from a team November 21, 2024 22:19
@utzcoz
Copy link
Contributor

utzcoz commented Nov 22, 2024

@gmackall Thanks for your ping. Yeah. I have updated Robolectric version for flutter/engine multiple times. This PR looks great to me. Sorry, but I don't have permission to approve it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants