Reverts "Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (#55402)" #55456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Sep 26, 2024
auto-submit
bot
deleted the
revert_746149965de9d31687096a857f58bec6fd71ec2b
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
…zation by splitting pictures" (flutter#55402)" (flutter/engine#55456)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 26, 2024
…155743) flutter/engine@fc6c852...896208e 2024-09-26 [email protected] Roll Skia from e5ce4ecbcf7b to d804bdf62b5e (1 revision) (flutter/engine#55455) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (#55402)" (flutter/engine#55456) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155743) flutter/engine@fc6c852...896208e 2024-09-26 [email protected] Roll Skia from e5ce4ecbcf7b to d804bdf62b5e (1 revision) (flutter/engine#55455) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter#55402)" (flutter/engine#55456) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155743) flutter/engine@fc6c852...896208e 2024-09-26 [email protected] Roll Skia from e5ce4ecbcf7b to d804bdf62b5e (1 revision) (flutter/engine#55455) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter#55402)" (flutter/engine#55456) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155743) flutter/engine@fc6c852...896208e 2024-09-26 [email protected] Roll Skia from e5ce4ecbcf7b to d804bdf62b5e (1 revision) (flutter/engine#55455) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter#55402)" (flutter/engine#55456) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155743) flutter/engine@fc6c852...896208e 2024-09-26 [email protected] Roll Skia from e5ce4ecbcf7b to d804bdf62b5e (1 revision) (flutter/engine#55455) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter#55402)" (flutter/engine#55456) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #55402
Initiated by: chingjun
Reason for reverting: caused internal tests to fail.
See b/369740500 for more details.
Original PR Author: harryterkelsen
Reviewed By: {yjbanov}
This change reverts the following previous change:
This enhances the overlay optimization by delaying combining pictures to get tighter bounds for the pictures that make up the scene, enabling more sophisticated optimization since we can determine if they intersect with platform views on a per-picture basis.
Fixes flutter/flutter#149863
On a Macbook in Chrome in an example app with an infinite scrolling grid of platform views, this brings the ratio of dropped frames from 93% to 55% (roughly 4 fps to 30 fps).
This is a reland of #54878 with a fix for scenes with pictures that are eventually entirely clipped out.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.