[Fuchsia] Use more high level fuchsia-gn-sdk templates #55445

zijiehe-google-com · 2024-09-25T21:33:23Z

This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk.

The build_fuchsia_artifacts.py is still using pm, and it will be handled in a following change.

Bug: http://b/353729557, http://b/368608542

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jrwang

LGTM

zijiehe-google-com · 2024-10-11T15:41:28Z

Thank you.

…tter/engine#55445)

zijiehe-google-com · 2024-10-11T17:45:58Z

Reason for revert: This change would break the build_fuchsia_artifacts.py without https://github.com/flutter/engine/pull/55832/files. I'd merge two into one.

auto-submit · 2024-10-11T17:46:00Z

A reason for requesting a revert of flutter/engine/55445 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. The build_fuchsia_artifacts.py is still using pm, and it will be handled in a following change. Bug: http://b/353729557, http://b/368608542 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

This reverts commit d13cbfb.

…)" (#55834) Reverts: #55445 Initiated by: zijiehe-google-com Reason for reverting: This change would break the build_fuchsia_artifacts.py without https://github.com/flutter/engine/pull/55832/files. I'd merge two into one. Original PR Author: zijiehe-google-com Reviewed By: {jrwang} This change reverts the following previous change: This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. The build_fuchsia_artifacts.py is still using pm, and it will be handled in a following change. Bug: http://b/353729557, http://b/368608542 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. The build_fuchsia_artifacts.py is still using pm, and it will be handled in a following change. Bug: http://b/353729557, http://b/368608542 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

…156602) flutter/engine@e41a762...d13cbfb 2024-10-11 [email protected] [Fuchsia] Use more high level fuchsia-gn-sdk templates (flutter/engine#55445) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. Also the use of pm in build_fuchsia_artifacts.py is removed as the placements of the binaries changed. #55445 was a previous attempt and it generates [a malformatted cipd](https://chrome-infra-packages.appspot.com/p/flutter/fuchsia/+/vU1Op26qgO5XYs9S8AqQMvBwgITD9hq3-2dIu2H5-iwC). Bug: http://b/353729557, http://b/368608542 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…#55922) Reverts: #55832 Initiated by: zijiehe-google-com Reason for reverting: may break roller. Original PR Author: zijiehe-google-com Reviewed By: {jrwang} This change reverts the following previous change: This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. Also the use of pm in build_fuchsia_artifacts.py is removed as the placements of the binaries changed. #55445 was a previous attempt and it generates [a malformatted cipd](https://chrome-infra-packages.appspot.com/p/flutter/fuchsia/+/vU1Op26qgO5XYs9S8AqQMvBwgITD9hq3-2dIu2H5-iwC). Bug: http://b/353729557, http://b/368608542 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Redo: #55832 See the diff of diffs, ``` diff <(curl -s 'https://github.com/flutter/engine/commit/1cd59a0c069a2436185b7009fa279afdb3b014cb.diff') <(curl -s 'https://github.com/flutter/engine/commit/97c7de37bccde02a8997f8f94ad9ea6527a0c18b.diff') ``` Or ``` 48c48 < index 5258466145387..83aebdaacd9b6 100755 --- > index 5258466145387..3f74d19640d0f 100755 141,142c141,142 < + far_file = '%s_%s%s_runner-0.far' % (runner_type, mode, '_product' if product else '') < + CopyPath('%s/%s' % (source_root, far_file), '%s/%s' % (destination, far_file)) --- > + far_file = '%s_%s%s_runner' % (runner_type, mode, '_product' if product else '') > + CopyPath('%s/%s-0.far' % (source_root, far_file), '%s/%s.far' % (destination, far_file)) ``` This change restores the files' -0 suffix which was wrongly removed in the last iteration. === Description of the original change: This change removes the in-house built pm-based build rules in favor of the high level fuchsia_component / fuchsia_package in the gn-sdk. Also the use of pm in build_fuchsia_artifacts.py is removed as the placements of the binaries changed. #55445 was a previous attempt and it generates [a malformatted cipd](https://chrome-infra-packages.appspot.com/p/flutter/fuchsia/+/vU1Op26qgO5XYs9S8AqQMvBwgITD9hq3-2dIu2H5-iwC). Bug: http://b/353729557, http://b/368608542 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

github-actions bot added the platform-fuchsia label Oct 9, 2024

zijiehe-google-com marked this pull request as ready for review October 9, 2024 21:10

zijiehe-google-com marked this pull request as draft October 9, 2024 21:10

zijiehe-google-com force-pushed the main branch 2 times, most recently from 80ad949 to a571511 Compare October 9, 2024 21:39

impl

8e68b75

zijiehe-google-com force-pushed the main branch from f4b26f0 to 8e68b75 Compare October 9, 2024 21:52

zijiehe-google-com and others added 6 commits October 10, 2024 10:15

TODO

319e858

Merge branch 'main' into main

4f8aa37

go

6f99e2f

debug

ed7aad8

build-id

1b3d3cc

Merge branch 'main' into main

ef6d82a

zijiehe-google-com marked this pull request as ready for review October 10, 2024 22:53

zijiehe-google-com requested review from jrwang and zanderso October 10, 2024 22:53

zijiehe-google-com added 2 commits October 10, 2024 16:17

Merge branch 'main' into main

04e4ca7

Merge branch 'main' into main

672224f

jrwang approved these changes Oct 11, 2024

View reviewed changes

zijiehe-google-com merged commit d13cbfb into flutter:main Oct 11, 2024
27 checks passed

engine-flutter-autoroll mentioned this pull request Oct 11, 2024

Roll Flutter Engine from e41a7629654a to d13cbfb6f38a (1 revision) flutter/flutter#156602

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 11, 2024

d13cbfb6f [Fuchsia] Use more high level fuchsia-gn-sdk templates (flu…

c8754c9

…tter/engine#55445)

zijiehe-google-com added the revert Label used to revert changes in a closed and merged pull request. label Oct 11, 2024

auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 11, 2024

zijiehe-google-com added the revert Label used to revert changes in a closed and merged pull request. label Oct 11, 2024

auto-submit bot pushed a commit that referenced this pull request Oct 11, 2024

Revert "[Fuchsia] Use more high level fuchsia-gn-sdk templates (#55445)"

3c73a59

This reverts commit d13cbfb.

auto-submit bot mentioned this pull request Oct 11, 2024

Reverts "[Fuchsia] Use more high level fuchsia-gn-sdk templates (#55445)" #55834

Merged

8 tasks

auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Oct 11, 2024

zijiehe-google-com mentioned this pull request Oct 11, 2024

[fuchsia] Remove pm use in build_fuchsia_artifacts #55832

Merged

8 tasks

auto-submit bot mentioned this pull request Oct 17, 2024

Reverts "[fuchsia] Remove pm use in build_fuchsia_artifacts (#55832)" #55922

Merged

8 tasks

zijiehe-google-com mentioned this pull request Oct 17, 2024

Reland: [fuchsia] Remove pm use in build_fuchsia_artifacts #55932

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fuchsia] Use more high level fuchsia-gn-sdk templates #55445

[Fuchsia] Use more high level fuchsia-gn-sdk templates #55445

zijiehe-google-com commented Sep 25, 2024 •

edited

Loading

jrwang left a comment

zijiehe-google-com commented Oct 11, 2024

zijiehe-google-com commented Oct 11, 2024 •

edited

Loading

auto-submit bot commented Oct 11, 2024

[Fuchsia] Use more high level fuchsia-gn-sdk templates #55445

[Fuchsia] Use more high level fuchsia-gn-sdk templates #55445

Conversation

zijiehe-google-com commented Sep 25, 2024 • edited Loading

Pre-launch Checklist

jrwang left a comment

Choose a reason for hiding this comment

zijiehe-google-com commented Oct 11, 2024

zijiehe-google-com commented Oct 11, 2024 • edited Loading

auto-submit bot commented Oct 11, 2024

zijiehe-google-com commented Sep 25, 2024 •

edited

Loading

zijiehe-google-com commented Oct 11, 2024 •

edited

Loading