Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] use public API for subpixel/color/emoji #55438

Closed
wants to merge 1 commit into from

Conversation

jonahwilliams
Copy link
Member

Fixes flutter/flutter#112005

THe strike context is really expensive to create, and is a private API anyway.

@jonahwilliams jonahwilliams marked this pull request as draft September 25, 2024 19:48
@jonahwilliams jonahwilliams removed the request for review from matanlurey September 25, 2024 19:48
@jonahwilliams
Copy link
Member Author

NVM, the skia API doesn't actually work as advertised.

@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@jonahwilliams jonahwilliams deleted the cache_strike_cache branch September 25, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Impeller] Need a public Skia API to look up whether a font+glyph is a bitmap or COLR font
1 participant